Summary: | OPAC list download button broken by Bootstrap 4 upgrade | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | julian.maurice, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
Circulation function: | |||
Bug Depends on: | 20168 | ||
Bug Blocks: | |||
Attachments: |
Bug 26752: Convert OPAC list download modal to dropdown
Bug 26752: Convert OPAC list download modal to dropdown Bug 26752: Convert OPAC list download modal to dropdown |
Description
Owen Leonard
2020-10-20 13:01:20 UTC
Created attachment 112041 [details] [review] Bug 26752: Convert OPAC list download modal to dropdown This patch modifies the OPAC list page so that download options are shown in a dropdown menu instead of a modal dialog. This solves a bug introduced by the Bootstrap 4 upgrade and makes it consistent with the cart interface. To test, apply the patch and view the contents of a list in the OPAC which has multiple items on it. - In the toolbar at the top of the list contents table the "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Created attachment 112229 [details] [review] Bug 26752: Convert OPAC list download modal to dropdown This patch modifies the OPAC list page so that download options are shown in a dropdown menu instead of a modal dialog. This solves a bug introduced by the Bootstrap 4 upgrade and makes it consistent with the cart interface. To test, apply the patch and view the contents of a list in the OPAC which has multiple items on it. - In the toolbar at the top of the list contents table the "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> I confirm that there is a bug in master, and that the patch fixes it Created attachment 112246 [details] [review] Bug 26752: Convert OPAC list download modal to dropdown This patch modifies the OPAC list page so that download options are shown in a dropdown menu instead of a modal dialog. This solves a bug introduced by the Bootstrap 4 upgrade and makes it consistent with the cart interface. To test, apply the patch and view the contents of a list in the OPAC which has multiple items on it. - In the toolbar at the top of the list contents table the "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! missing dependencies for 20.05.x, no backport |