| Summary: | Make the guarantor search popup taller | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Barbara Johnson <barbara.johnson> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | andrew, anneli.osterman, caroline.cyr-la-rose, fridolin.somers, gmcharlt, kyle.m.hall, lucas, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.03,20.05.09
|
|
| Circulation function: | |||
| Attachments: |
Current popup window
Taller popup window showing search result Bug 26755: Make the guarantor search popup taller Bug 26755: Make the guarantor search popup taller Bug 26755: Make the guarantor search popup taller |
||
Created attachment 112043 [details]
Taller popup window showing search result
This would be nice improvement. Created attachment 115700 [details] [review] Bug 26755: Make the guarantor search popup taller This patch changes the dimensions of the popup window in which guarantors are chosen during the patron edit process. The patch also removes an obsolete function delcaration for "Dopop" which is unused. To test, apply the patch and open a "child" type patron account for editing. Click the "Add guarantor" button. This should trigger a popup window. Eyeball the size of the window, you'll be able to tell that it is exactly 800 pixels wide. Created attachment 115701 [details] [review] Bug 26755: Make the guarantor search popup taller This patch changes the dimensions of the popup window in which guarantors are chosen during the patron edit process. The patch also removes an obsolete function delcaration for "Dopop" which is unused. To test, apply the patch and open a "child" type patron account for editing. Click the "Add guarantor" button. This should trigger a popup window. Eyeball the size of the window, you'll be able to tell that it is exactly 800 pixels wide. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 115912 [details] [review] Bug 26755: Make the guarantor search popup taller This patch changes the dimensions of the popup window in which guarantors are chosen during the patron edit process. The patch also removes an obsolete function delcaration for "Dopop" which is unused. To test, apply the patch and open a "child" type patron account for editing. Click the "Add guarantor" button. This should trigger a popup window. Eyeball the size of the window, you'll be able to tell that it is exactly 800 pixels wide. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Small enhancement very useful, I choose to backport. Pushed to 20.11.x for 20.11.03 There are several places with small popups, maybe we should always use the same size ? https://git.koha-community.org/Koha-community/Koha/search?q=height%3D400 Pushed to 20.05.x for 20.05.09 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |
Created attachment 112042 [details] Current popup window When searching for a guarantor to add to a guarantee you can't see the search results in the the popup search window (guarantor_search.pl) without scrolling. Although the popup window shouldn't be too tall it would be helpful to display at least the first one or two entries which could eliminate extra scrolling and allow staff to select the record more efficiently.