Bug 26767

Summary: Remove the use of jquery.checkboxes plugin from duplicate orders template
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.11.00
Circulation function:
Bug Depends on:    
Bug Blocks: 26006, 26806    
Attachments: Bug 26767: Remove the use of jquery.checkboxes plugin from duplicate orders template
Bug 26767: Remove the use of jquery.checkboxes plugin from duplicate orders template
Bug 26767: Remove the use of jquery.checkboxes plugin from duplicate orders template

Description Owen Leonard 2020-10-21 15:31:54 UTC
As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. 

Its use should replaced in the staff interface on the acquisitions "duplicate orders" page.
Comment 1 Owen Leonard 2020-10-21 17:45:01 UTC
Created attachment 112116 [details] [review]
Bug 26767: Remove the use of jquery.checkboxes plugin from duplicate orders template

This patch removes the use of the jquery.checkboxes plugin from the
duplicate orders template in acquisitions.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket.

- Click "Add to basket."
- Click "From existing orders (copy)."
- Perform a search which will return some orders.
- Test the "Select all" and "Clear all" links. Confirm that they work
  correctly.
Comment 2 David Nind 2020-10-25 03:11:37 UTC
Created attachment 112467 [details] [review]
Bug 26767: Remove the use of jquery.checkboxes plugin from duplicate orders template

This patch removes the use of the jquery.checkboxes plugin from the
duplicate orders template in acquisitions.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket.

- Click "Add to basket."
- Click "From existing orders (copy)."
- Perform a search which will return some orders.
- Test the "Select all" and "Clear all" links. Confirm that they work
  correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2020-10-25 13:36:39 UTC
Created attachment 112475 [details] [review]
Bug 26767: Remove the use of jquery.checkboxes plugin from duplicate orders template

This patch removes the use of the jquery.checkboxes plugin from the
duplicate orders template in acquisitions.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket.

- Click "Add to basket."
- Click "From existing orders (copy)."
- Perform a search which will return some orders.
- Test the "Select all" and "Clear all" links. Confirm that they work
  correctly.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2020-11-03 09:59:13 UTC
Pushed to master for 20.11, thanks to everybody involved!