Bug 26779

Summary:	Make desk selection consistent in auth.tt and set-library.tt
Product:	Koha	Reporter:	Nicolas Legrand <nicolas.legrand>
Component:	Circulation	Assignee:	Bugs List <koha-bugs>
Status:	Patch doesn't apply ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	gmcharlt, kyle.m.hall, severine.queune, stina.hallin
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 26779: Make desk selection consistent in auth.tt and set-library.tt

Description Nicolas Legrand 2020-10-22 10:01:36 UTC

When changing libraries in set-library.tt, the desks selection list print only desk. The desk list is printed with a different code from auth.pp but modified by the same javascript. Make the template code consistent and work for both pages.

Comment 1 Nicolas Legrand 2020-10-22 10:09:14 UTC

Created attachment 112158 [details] [review]
Bug 26779: Make desk selection consistent in auth.tt and set-library.tt

When changing libraries in set-library.tt, the desks selection list
prints only one desk. The desk list is printed with a different code
from auth.pp but modified by the same javascript. Make the template
code consistent and work for both pages.

Test plan:

    1. have at least two libraries with multiple desks and one without
    any desk.
    2. go to set-library.pl, select the library without desks, you
    should see only a “---” entry.
    3. select a library you're not logged in and you should see only
    one desk entry.
    4. apply patch.
    5. recheck 2. should still be ok.
    6. recheck 3. this time you should see all desks.
    7. check you can log and set desks as expected from auth.pp.

Comment 2 Stina Hallin 2021-03-12 13:14:21 UTC

CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc