Summary: | JS errors in pos/pay.tt in 20.05.x | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Fines and fees | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P3 | CC: | aleisha, jonathan.druart, martin.renvoize |
Version: | 20.05 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.05
|
Circulation function: | |
Attachments: |
Bug 26785: Fix JS error in pos/pay.tt
Bug 26785: Fix JS error in pos/pay.tt Bug 26785: Fix JS error in pos/pay.tt |
Description
Lucas Gass (lukeg)
2020-10-22 16:27:40 UTC
I think line 338 is a backporting error and that it doesn't belong: }, items_columns_settings, false); (In reply to Owen Leonard from comment #1) > I think line 338 is a backporting error and that it doesn't belong: > > }, items_columns_settings, false); Ahh, indeed. From this commit I think: http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt;h=1fda1baa55c11b609595c1493c79c7b117251e95;hp=87cbd926a559940edbacbe687f2d3190d15962c1;hb=2c5cd4ffbe762164cfcf5d603e926fe177bb642c;hpb=59b67c3b37ed92926e9c75c0637c58af255ecec2 Created attachment 112273 [details] [review] Bug 26785: Fix JS error in pos/pay.tt To Test: 1. enable EnablePointOfSale 2. enable UseCashRegisters 3. Go to /cgi-bin/koha/pos/pay.pl 4. See the console error 5. Apply patch 6. Add some debit types and make sure you can add them /cgi-bin/koha/pos/pay.pl 7. Check for console errors, there should be none 8. Make sure you can confrim payments. Created attachment 112406 [details] [review] Bug 26785: Fix JS error in pos/pay.tt To Test: 1. enable EnablePointOfSale 2. enable UseCashRegisters 3. Go to /cgi-bin/koha/pos/pay.pl 4. See the console error 5. Apply patch 6. Add some debit types and make sure you can add them /cgi-bin/koha/pos/pay.pl 7. Check for console errors, there should be none 8. Make sure you can confrim payments. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 112436 [details] [review] Bug 26785: Fix JS error in pos/pay.tt To Test: 1. enable EnablePointOfSale 2. enable UseCashRegisters 3. Go to /cgi-bin/koha/pos/pay.pl 4. See the console error 5. Apply patch 6. Add some debit types and make sure you can add them /cgi-bin/koha/pos/pay.pl 7. Check for console errors, there should be none 8. Make sure you can confrim payments. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Sending to 20.05 RMaint queue. backported to 20.05.x for 20.05.05. Thanks everyone! missing dependencies, not backported to 19.11.x |