Bug 26787

Summary: getletter does not fallback to default language - transaction receipts can be blank
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Fines and feesAssignee: Bugs List <koha-bugs>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Nick Clemens (kidclamp) 2020-10-22 18:52:01 UTC
getletter does not fallback to default language, it searches for a language if passed then gives up

To recreate
1 - Enable 'TranslateNotices' syspref
2 - Define ACCOUNT_CREDIT notice for print transport in default language
3 - Make sure 'English (en)' notice is not defined
4 - Make a payment on a patrons account
5 - Go to the patrons transactions and click 'Print' on the payment
6 - Is blank?
7 - Copy notice from default to english
8 - Try again, it works
Comment 1 Jonathan Druart 2021-06-04 10:27:20 UTC
getletter must not fallback, see also bug 27660.

And bug 28514.

*** This bug has been marked as a duplicate of bug 27660 ***
Comment 2 Martin Renvoize (ashimema) 2021-06-10 12:08:07 UTC
Please also see bug 28374 Nick.. it converts pos/printreciept to use GetPreparedLetter.