Bug 26798

Summary: Remove the use of jquery.checkboxes plugin from patron detail page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to master --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart+koha, testopia
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:
20.11.00
Bug Depends on:    
Bug Blocks: 26806, 26006    
Attachments: Bug 26798: Remove the use of jquery.checkboxes plugin from patron detail page
Attachment to Bug 26798 - Remove the use of jquery.checkboxes plugin from patron detail page
Bug 26798: Remove the use of jquery.checkboxes plugin from patron detail page

Description Owen Leonard 2020-10-23 13:34:04 UTC
The patron detail page (moremember.tt) includes the jquery.checkboxes plugin but do not use them. The include should be removed.
Comment 1 Owen Leonard 2020-10-23 13:45:23 UTC
Created attachment 112274 [details] [review]
Bug 26798: Remove the use of jquery.checkboxes plugin from patron detail page

This patch removes inclusion of the jquery.checkboxes plugin from the
patron detail page (moremember.tt). The plugin is unused.

To test, apply the patch and locate a patron with checkouts.

- View the details for that patron.
- Open the checkouts tab and click "Show checkouts" if necessary.
- In the table of checkouts, confirm that the "select all" and "none"
  links in the "Renew" and "Check in" column headers work correctly.
Comment 2 Lisette Scheer 2020-10-24 20:21:23 UTC
Created attachment 112398 [details] [review]
Attachment to Bug 26798 - Remove the use of jquery.checkboxes plugin from patron detail page

Bug 26798: Remove the use of jquery.checkboxes plugin from patron detail page

This patch removes inclusion of the jquery.checkboxes plugin from the
patron detail page (moremember.tt). The plugin is unused.

To test, apply the patch and locate a patron with checkouts.

- View the details for that patron.
- Open the checkouts tab and click "Show checkouts" if necessary.
- In the table of checkouts, confirm that the "select all" and "none"
  links in the "Renew" and "Check in" column headers work correctly.

Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org>
Comment 3 Katrin Fischer 2020-10-25 01:25:50 UTC
Created attachment 112443 [details] [review]
Bug 26798: Remove the use of jquery.checkboxes plugin from patron detail page

This patch removes inclusion of the jquery.checkboxes plugin from the
patron detail page (moremember.tt). The plugin is unused.

To test, apply the patch and locate a patron with checkouts.

- View the details for that patron.
- Open the checkouts tab and click "Show checkouts" if necessary.
- In the table of checkouts, confirm that the "select all" and "none"
  links in the "Renew" and "Check in" column headers work correctly.

Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2020-11-03 09:59:28 UTC
Pushed to master for 20.11, thanks to everybody involved!