Bug 26800

Summary: Remove the use of jquery.checkboxes plugin from checkout page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, testopia
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
20.11.00
Circulation function:
Bug Depends on:    
Bug Blocks: 26006, 26806    
Attachments: Bug 26800: Remove the use of jquery.checkboxes plugin from checkout page
Attachment to Bug 26800 - Remove the use of jquery.checkboxes plugin from checkout page
Bug 26800: Remove the use of jquery.checkboxes plugin from checkout page

Description Owen Leonard 2020-10-23 14:37:27 UTC
The checkout page (circulation.tt) includes the jquery.checkboxes plugin but does not use it. The include should be removed.
Comment 1 Owen Leonard 2020-10-23 14:50:37 UTC
Created attachment 112294 [details] [review]
Bug 26800: Remove the use of jquery.checkboxes plugin from checkout page

This patch removes inclusion of the jquery.checkboxes plugin from the
patron checkout page (circulation.tt). The plugin is unused.

To test, apply the patch and check out to a patron with checkouts.

- Open the checkouts tab and click "Show checkouts" if necessary.
- In the table of checkouts, confirm that the "select all" and "none"
  links in the "Renew" and "Check in" column headers work correctly.
Comment 2 Lisette Scheer 2020-10-24 20:08:44 UTC
Created attachment 112396 [details] [review]
Attachment to Bug 26800 - Remove the use of jquery.checkboxes plugin from checkout page

Bug 26800: Remove the use of jquery.checkboxes plugin from checkout page

This patch removes inclusion of the jquery.checkboxes plugin from the
patron checkout page (circulation.tt). The plugin is unused.

To test, apply the patch and check out to a patron with checkouts.

- Open the checkouts tab and click "Show checkouts" if necessary.
- In the table of checkouts, confirm that the "select all" and "none"
  links in the "Renew" and "Check in" column headers work correctly.

Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org>
Comment 3 Katrin Fischer 2020-10-25 01:19:50 UTC
Created attachment 112440 [details] [review]
Bug 26800: Remove the use of jquery.checkboxes plugin from checkout page

This patch removes inclusion of the jquery.checkboxes plugin from the
patron checkout page (circulation.tt). The plugin is unused.

To test, apply the patch and check out to a patron with checkouts.

- Open the checkouts tab and click "Show checkouts" if necessary.
- In the table of checkouts, confirm that the "select all" and "none"
  links in the "Renew" and "Check in" column headers work correctly.

Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2020-11-03 09:59:35 UTC
Pushed to master for 20.11, thanks to everybody involved!