| Summary: | Use confirmation modal when removing titles from a list in the OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, david, fridolin.somers, lisettepalouse+koha, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/837 |
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 26805 | ||
| Bug Blocks: | 36207 | ||
| Attachments: |
Bug 26824: Use confirmation modal when removing titles from a list in the OPAC
Bug 26824: Use confirmation modal when removing titles from a list in the OPAC Bug 26824: Use confirmation modal when removing titles from a list in the OPAC Bug 26824: Use confirmation modal when removing titles from a list in the OPAC |
||
|
Description
Owen Leonard
2020-10-26 19:05:45 UTC
Created attachment 112723 [details] [review] Bug 26824: Use confirmation modal when removing titles from a list in the OPAC This patch changes the process of removing a title from a list so that it uses a confirmation modal dialog instead of a JavaScript alert. To test, apply the patch and view the contents of a list in the OPAC. - Click the "Remove from this list" link under one of the titles. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title of the item on the list. - Test both the "Yes" and "No" choices. - Check the box next to one title on the list, and click the "Remove from list" link at the top of the table. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title of the item on the list. - Test boh the "Yes" and "No" choices. - Check the box next to multiple titles on the list and clcik the "Remove from list" link at the top of the table. - You should see a modal confirmation message, "Are you sure you want to remove these items from the list?" It should show the titles of all the records you selected. - Test both the "Yes" and "No" choices. Patch no longer applies 8-( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 26824: Use confirmation modal when removing titles from a list in the OPAC Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 26824: Use confirmation modal when removing titles from a list in OPAC Created attachment 157565 [details] [review] Bug 26824: Use confirmation modal when removing titles from a list in the OPAC This patch changes the process of removing a title from a list so that it uses a confirmation modal dialog instead of a JavaScript alert. To test, apply the patch and view the contents of a list in the OPAC. - Click the "Remove from this list" link under one of the titles. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title of the item on the list. - Test both the "Yes" and "No" choices. - Check the box next to one title on the list, and click the "Remove from list" link at the top of the table. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title of the item on the list. - Test boh the "Yes" and "No" choices. - Check the box next to multiple titles on the list and click the "Remove from list" link at the top of the table. - You should see a modal confirmation message, "Are you sure you want to remove these items from the list?" It should show the titles of all the records you selected. - Test both the "Yes" and "No" choices. Created attachment 157582 [details] [review] Bug 26824: Use confirmation modal when removing titles from a list in the OPAC This patch changes the process of removing a title from a list so that it uses a confirmation modal dialog instead of a JavaScript alert. To test, apply the patch and view the contents of a list in the OPAC. - Click the "Remove from this list" link under one of the titles. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title of the item on the list. - Test both the "Yes" and "No" choices. - Check the box next to one title on the list, and click the "Remove from list" link at the top of the table. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title of the item on the list. - Test boh the "Yes" and "No" choices. - Check the box next to multiple titles on the list and click the "Remove from list" link at the top of the table. - You should see a modal confirmation message, "Are you sure you want to remove these items from the list?" It should show the titles of all the records you selected. - Test both the "Yes" and "No" choices. Signed-off-by: David Nind <david@davidnind.com> Created attachment 158174 [details] [review] Bug 26824: Use confirmation modal when removing titles from a list in the OPAC This patch changes the process of removing a title from a list so that it uses a confirmation modal dialog instead of a JavaScript alert. To test, apply the patch and view the contents of a list in the OPAC. - Click the "Remove from this list" link under one of the titles. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title of the item on the list. - Test both the "Yes" and "No" choices. - Check the box next to one title on the list, and click the "Remove from list" link at the top of the table. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title of the item on the list. - Test boh the "Yes" and "No" choices. - Check the box next to multiple titles on the list and click the "Remove from list" link at the top of the table. - You should see a modal confirmation message, "Are you sure you want to remove these items from the list?" It should show the titles of all the records you selected. - Test both the "Yes" and "No" choices. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |