Summary: | Add missing X11$e and remove relator term subfields from MARC21 headings | ||
---|---|---|---|
Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
Component: | MARC Bibliographic data support | Assignee: | Janusz Kaczmarek <januszop> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, fridolin.somers, januszop, jonathan.druart, kyle, phil, sbrown, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This patch adds $e to 111 and 611, but removes it from 100 and 110 as it's used for the relator term there and should not be copied. Same for 111$j.
|
|
Version(s) released in: |
21.11.00,21.05.03,20.11.10
|
Circulation function: | |
Attachments: |
Bug 26852 -- subfield $e missing in X11 definition of MARC21 headings
Bug 26852 -- subfield $e missing in X11 definition of MARC21 headings Bug 26852: subfield $e missing in X11 definition of MARC21 headings Bug 26852: subfield $e missing in X11 definition of MARC21 headings Bug 26852: Fix Heading.t |
Description
Janusz Kaczmarek
2020-10-28 23:56:37 UTC
Created attachment 112654 [details] [review] Bug 26852 -- subfield $e missing in X11 definition of MARC21 headings Test plan: 1. Have a biblio record with, for example, 711 field with a $e subfield. 2. Have two auth records: one with 111 field reflecting the 711 field and second similar but without $e subfield 3. Have LinkerModule set to Default 4. Run link_bibs_to_authorities.pl 5. 711 should remain unlinked since there were two record found by the Default Linker and no one was chosen. 6. Apply the patch. 7. Run link_bibs_to_authorities.pl 8. 711 should be linked now. NB zebra index definition is OK: kohaidx:index_match_heading tag="111" subfields="acdefghjklnpqstvxyz" subdivisions="vxyz"> in etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml e is almost certainly missing because in x00 and x10 it's the Relator term, which shouldn't be included, so you should also remove j from x11, so a heading with a j will link correctly. (In reply to Phil Ringnalda from comment #2) > e is almost certainly missing because in x00 and x10 it's the Relator term, > which shouldn't be included, so you should also remove j from x11, so a > heading with a j will link correctly. Yes, you are right. I missed the $j which should be removed from X11 controlled subfields list (as it contains the relator term). A corrected version of the patch follows. Created attachment 120284 [details] [review] Bug 26852 -- subfield $e missing in X11 definition of MARC21 headings A corrected version of the patch. BTW, it removes $e from the subfields list for 100 and 110 in $auth_heading_fields, introduced (by mistake?) by patch 21958 (which was rather wrong - $e should not be controlled by authority record in X00 and X10 fields, as it contains a relator term). I followed this and it worked as intended - sign-off through sandbox didn't work properly so am signing off here. Created attachment 123665 [details] [review] Bug 26852: subfield $e missing in X11 definition of MARC21 headings This patch adds $e to 111 and 611, but removes it from 100 and 110 as it's used for the relator term there and should not be copied. Same for 111$j. Test plan: 1. Have a biblio record with, for example, 711 field with a $e subfield. 2. Have two auth records: one with 111 field reflecting the 711 field and second similar but without $e subfield 3. Have LinkerModule set to Default 4. Run link_bibs_to_authorities.pl 5. 711 should remain unlinked since there were two record found by the Default Linker and no one was chosen. 6. Apply the patch. 7. Run link_bibs_to_authorities.pl 8. 711 should be linked now. Repeat testing in similar fashion for authorities: 9. 100/110 $e 10. 111 $j NB zebra index definition is OK: kohaidx:index_match_heading tag="111" subfields="acdefghjklnpqstvxyz" subdivisions="vxyz"> in etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml Signed-off-by: S. Brown <sbrown@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I've added a sign-off line for "S. Brown" manually using the email address from the bugzilla account. Also amended the test plan and commit message a bit to reflect the additional fixes for $e/$j relator terms. Created attachment 123780 [details] [review] Bug 26852: subfield $e missing in X11 definition of MARC21 headings This patch adds $e to 111 and 611, but removes it from 100 and 110 as it's used for the relator term there and should not be copied. Same for 111$j. Test plan: 1. Have a biblio record with, for example, 711 field with a $e subfield. 2. Have two auth records: one with 111 field reflecting the 711 field and second similar but without $e subfield 3. Have LinkerModule set to Default 4. Run link_bibs_to_authorities.pl 5. 711 should remain unlinked since there were two record found by the Default Linker and no one was chosen. 6. Apply the patch. 7. Run link_bibs_to_authorities.pl 8. 711 should be linked now. Repeat testing in similar fashion for authorities: 9. 100/110 $e 10. 111 $j NB zebra index definition is OK: kohaidx:index_match_heading tag="111" subfields="acdefghjklnpqstvxyz" subdivisions="vxyz"> in etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml Signed-off-by: Sara Brown <sbrown@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #7) > I've added a sign-off line for "S. Brown" manually using the email address > from the bugzilla account. First name adjusted. Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 Created attachment 123852 [details] [review] Bug 26852: Fix Heading.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Jonathan Druart from comment #12) > Created attachment 123852 [details] [review] [review] > Bug 26852: Fix Heading.t > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Patch pushed to master. Bug 21958 as impacted C4::Heading::MARC21 Pushed to 20.11.x for 20.11.10 Note that 20.11 does not contain Bug 21958 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |