Summary: | Purchase suggestion button hidden for users with suggestion permission but not acq permission | ||
---|---|---|---|
Product: | Koha | Reporter: | Phil <gormanp> |
Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, bolshawh, caroline.cyr-la-rose, fridolin.somers, jonathan.druart, martin.renvoize, oleonard, philip.orr, victor |
Version: | Main | Keywords: | Manual |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Philip Orr | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/823 |
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.01, 20.05.07
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 27260 | ||
Attachments: |
Screenshot of proposed change
Bug 26905: Purchase suggestion button hidden for users with suggestion permission but not acq permission Bug 26905: Purchase suggestion button hidden for users with suggestion permission but not acq permission Bug 26905: Purchase suggestion button hidden for users with suggestion permission but not acq permission |
Description
Phil
2020-11-03 09:31:18 UTC
Owen, Katrin, do you have any ideas where we could add this link? Created attachment 114096 [details]
Screenshot of proposed change
I suggest we add it to the "More" menu in the header
Created attachment 114097 [details] [review] Bug 26905: Purchase suggestion button hidden for users with suggestion permission but not acq permission This patch adds a link to purchase suggestions from the header menu's "More" submenu for users with suggestions management permission. To test, apply the patch and log in to the staff interface as a user with "suggestions_manage" permission. - Click the "More" menu item in the header. You should see a link to "Suggestions" which takes you to the suggestions management page. - Log in as a user without "suggestions_manage" permission. The link should not appear. Yes, I thought about that as well. Maybe after "Acquisition"? Right now it's between a R and T, but others are not alpha ordered :) And... maybe we weird "suggestion", but shouldn't we display it only if it's not accessible from the acquisition module? (In reply to Jonathan Druart from comment #5) > And... maybe we weird "suggestion", but shouldn't we display it only if it's > not accessible from the acquisition module? I don't see any reason to hide it. Whether or not the user has acquisitions permissions it's still a tool that one might want to access directly. Created attachment 114158 [details] [review] Bug 26905: Purchase suggestion button hidden for users with suggestion permission but not acq permission This patch adds a link to purchase suggestions from the header menu's "More" submenu for users with suggestions management permission. To test, apply the patch and log in to the staff interface as a user with "suggestions_manage" permission. - Click the "More" menu item in the header. You should see a link to "Suggestions" which takes you to the suggestions management page. - Log in as a user without "suggestions_manage" permission. The link should not appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 114239 [details] [review] Bug 26905: Purchase suggestion button hidden for users with suggestion permission but not acq permission This patch adds a link to purchase suggestions from the header menu's "More" submenu for users with suggestions management permission. To test, apply the patch and log in to the staff interface as a user with "suggestions_manage" permission. - Click the "More" menu item in the header. You should see a link to "Suggestions" which takes you to the suggestions management page. - Log in as a user without "suggestions_manage" permission. The link should not appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice little fix, works well. Passing QA Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.01 Pushed to 20.05.x for 20.05.07 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |