Summary: | Tagging: Add filter by name | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Tools | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P3 | CC: | fridolin.somers, gitbot, gmcharlt, jonathan.druart, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
screenshot 1
Screenshot 2 Bug 2693 - Tagging: Add filter by name Bug 2693 - Tagging: Add filter by name Bug 2693 - Tagging: Add filter by name Bug 2693 - Tagging: Add filter by name Bug 2693 - Tagging: Add filter by name |
Description
Chris Cormack
2010-05-21 00:54:46 UTC
Created attachment 20539 [details] [review] Bug 2693 - Tagging: Add filter by name If you want to filter results on the tags management page by the reviewer you have to know their borrowernumber. It would be better to be able to search by name, but in the meantime this patch adds an autocomplete widget to the form field so that you can do a name search and populate the field with the borrowernumber. To test you must have approved or rejected tags. From the tags review page (tags/review.pl), view all, approved, or rejected tags. Type a name in the "reviewer" form field in the left sidebar filter. You should get an autocomplete dropdown with names matching your search. When you select one the form field should be populated by the borrowernumber. Applying: Bug 2693 - Tagging: Add filter by name Using index info to reconstruct a base tree... M circ/ysearch.pl Falling back to patching base and 3-way merge... Auto-merging circ/ysearch.pl CONFLICT (content): Merge conflict in circ/ysearch.pl Patch failed at 0001 Bug 2693 - Tagging: Add filter by name The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Created attachment 21202 [details] [review] Bug 2693 - Tagging: Add filter by name If you want to filter results on the tags management page by the reviewer you have to know their borrowernumber. It would be better to be able to search by name, but in the meantime this patch adds an autocomplete widget to the form field so that you can do a name search and populate the field with the borrowernumber. To test you must have approved or rejected tags. From the tags review page (tags/review.pl), view all, approved, or rejected tags. Type a name in the "reviewer" form field in the left sidebar filter. You should get an autocomplete dropdown with names matching your search. When you select one the form field should be populated by the borrowernumber. Applying: Bug 2693 - Tagging: Add filter by name Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt Patch failed at 0001 Bug 2693 - Tagging: Add filter by name The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Created attachment 22085 [details] [review] Bug 2693 - Tagging: Add filter by name If you want to filter results on the tags management page by the reviewer you have to know their borrowernumber. It would be better to be able to search by name, but in the meantime this patch adds an autocomplete widget to the form field so that you can do a name search and populate the field with the borrowernumber. To test you must have approved or rejected tags. From the tags review page (tags/review.pl), view all, approved, or rejected tags. Type a name in the "reviewer" form field in the left sidebar filter. You should get an autocomplete dropdown with names matching your search. When you select one the form field should be populated by the borrowernumber. Created attachment 22289 [details] [review] Bug 2693 - Tagging: Add filter by name If you want to filter results on the tags management page by the reviewer you have to know their borrowernumber. It would be better to be able to search by name, but in the meantime this patch adds an autocomplete widget to the form field so that you can do a name search and populate the field with the borrowernumber. To test you must have approved or rejected tags. From the tags review page (tags/review.pl), view all, approved, or rejected tags. Type a name in the "reviewer" form field in the left sidebar filter. You should get an autocomplete dropdown with names matching your search. When you select one the form field should be populated by the borrowernumber. Signed-off-by: David Cook <dcook@prosentient.com.au> Patch works as described. I'm not sure whether or not it would be better to be able to search by name, as that would involve either choosing between names after applying the filter or showing any possible matches, so this seems fine. -- Owen and I did observe that we were able to cause AJAX errors while using this autocomplete, but we are not 100% sure how we caused the error. In my case, I was able to occasionally cause it by typing in a name then backspacing rapidly. The ajaxError method is attached to every element in the DOM (yikes) so it's tough to say what exactly is the source of the error (which is signalled by a pop-up window that can be cancelled). The error is quite rare so I don't think it's necessarily a problem for us. One idea that Owen had was to remove the current error message, which is very unhelpful and replace it with an error like "Something went wrong. Try again." QA comment: I reproduced the error described by David, but just one time. I don't think it is critical. However, the autocomplete is often dependent on the CircAutocompl pref (request.tt, patron search header), but not always (patron list, course reserve). Since we are not in the circulation module, maybe this pref should not be check. But I suppose this pref exists in order to avoid performance issue. I am leaning towards to mark as passed QA this patch but I let the last word to the RM (as always, of course ;)) Created attachment 22780 [details] [review] Bug 2693 - Tagging: Add filter by name If you want to filter results on the tags management page by the reviewer you have to know their borrowernumber. It would be better to be able to search by name, but in the meantime this patch adds an autocomplete widget to the form field so that you can do a name search and populate the field with the borrowernumber. To test you must have approved or rejected tags. From the tags review page (tags/review.pl), view all, approved, or rejected tags. Type a name in the "reviewer" form field in the left sidebar filter. You should get an autocomplete dropdown with names matching your search. When you select one the form field should be populated by the borrowernumber. Signed-off-by: David Cook <dcook@prosentient.com.au> Patch works as described. I'm not sure whether or not it would be better to be able to search by name, as that would involve either choosing between names after applying the filter or showing any possible matches, so this seems fine. -- Owen and I did observe that we were able to cause AJAX errors while using this autocomplete, but we are not 100% sure how we caused the error. In my case, I was able to occasionally cause it by typing in a name then backspacing rapidly. The ajaxError method is attached to every element in the DOM (yikes) so it's tough to say what exactly is the source of the error (which is signalled by a pop-up window that can be cancelled). The error is quite rare so I don't think it's necessarily a problem for us. One idea that Owen had was to remove the current error message, which is very unhelpful and replace it with an error like "Something went wrong. Try again." Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Owen! This patch has been pushed to 3.14.x, will be in 3.14.1 |