| Summary: | Prevent flash of unstyled content on sales table | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Staff interface | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew, dcook, gmcharlt, josef.moravec, sally.healey, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.07
|
|
| Circulation function: | |||
| Bug Depends on: | 26172 | ||
| Bug Blocks: | 26939 | ||
| Attachments: |
Bug 26938: Prevent flash of unstyled sales table
Bug 26938: Prevent flash of unstyled sales table Bug 26938: Prevent flash of unstyled sales table |
||
|
Description
Martin Renvoize (ashimema)
2020-11-05 13:43:26 UTC
Created attachment 113115 [details] [review] Bug 26938: Prevent flash of unstyled sales table On the registers page the table has come complex data structures embedded to allow for all the functionality we bring into the datatable. We should hide the table on page load and only display it at DataTables init time once the weird content has been beautified by DataTables. Test plan 1/ Enable 'UseCashRegisters' and 'EnablePointOfSale' 2/ Add a cash register and make some transactions against it. 3/ Navigate to the 'Register details' page 4/ Note that some 'funky' JSON strings appear in the table briefly before it is restyled when DataTables loads. 5/ Apply the patch 6/ Rebuild the CSS from the SCSS files 7/ Reload the page (hard reload to get the CSS changes) 8/ Note that the table now only appears once the nice formatting that DataTables adds is applied. Created attachment 113218 [details] [review] Bug 26938: Prevent flash of unstyled sales table On the registers page the table has come complex data structures embedded to allow for all the functionality we bring into the datatable. We should hide the table on page load and only display it at DataTables init time once the weird content has been beautified by DataTables. Test plan 1/ Enable 'UseCashRegisters' and 'EnablePointOfSale' 2/ Add a cash register and make some transactions against it. 3/ Navigate to the 'Register details' page 4/ Note that some 'funky' JSON strings appear in the table briefly before it is restyled when DataTables loads. 5/ Apply the patch 6/ Rebuild the CSS from the SCSS files 7/ Reload the page (hard reload to get the CSS changes) 8/ Note that the table now only appears once the nice formatting that DataTables adds is applied. Signed-off-by: David Nind <david@davidnind.com> Thumbs up for this idea Created attachment 113751 [details] [review] Bug 26938: Prevent flash of unstyled sales table On the registers page the table has come complex data structures embedded to allow for all the functionality we bring into the datatable. We should hide the table on page load and only display it at DataTables init time once the weird content has been beautified by DataTables. Test plan 1/ Enable 'UseCashRegisters' and 'EnablePointOfSale' 2/ Add a cash register and make some transactions against it. 3/ Navigate to the 'Register details' page 4/ Note that some 'funky' JSON strings appear in the table briefly before it is restyled when DataTables loads. 5/ Apply the patch 6/ Rebuild the CSS from the SCSS files 7/ Reload the page (hard reload to get the CSS changes) 8/ Note that the table now only appears once the nice formatting that DataTables adds is applied. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 20.11, thanks to everybody involved! Missing dependencies, not backporting to 20.05.x Decided to backport this after all. It's not strictly dependent on 26172, applies fine without it. Backported to 20.05.x for 20.05.07 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |