| Summary: | Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.01,20.05.07
|
|
| Circulation function: | |||
| Attachments: |
Bug 26956: Allow guarantor's controls to be set when a guarantee is created
Bug 26956: Allow guarantor's controls to be set when a guarantee is created Bug 26956: Allow guarantor's controls to be set when a guarantee is created |
||
|
Description
Andrew Fuerste-Henry
2020-11-06 15:36:23 UTC
Created attachment 114088 [details] [review] Bug 26956: Allow guarantor's controls to be set when a guarantee is created With AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor set to Allow, one can only see the controls for these values in the patron record *after* the patron has been saved with a guarantor. That makes a frustrating 2-step process. We should be able to set those values regardless of whether or not there is currently a guarantor on the account. Test plan: Create a guarantee and confirm that the 2 options "Show checkouts to guarantors" and "Show fines to guarantors" are displayed Select Yes, save Confirm that the values have been correctly saved Created attachment 114294 [details] [review] Bug 26956: Allow guarantor's controls to be set when a guarantee is created With AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor set to Allow, one can only see the controls for these values in the patron record *after* the patron has been saved with a guarantor. That makes a frustrating 2-step process. We should be able to set those values regardless of whether or not there is currently a guarantor on the account. Test plan: Create a guarantee and confirm that the 2 options "Show checkouts to guarantors" and "Show fines to guarantors" are displayed Select Yes, save Confirm that the values have been correctly saved Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 114704 [details] [review] Bug 26956: Allow guarantor's controls to be set when a guarantee is created With AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor set to Allow, one can only see the controls for these values in the patron record *after* the patron has been saved with a guarantor. That makes a frustrating 2-step process. We should be able to set those values regardless of whether or not there is currently a guarantor on the account. Test plan: Create a guarantee and confirm that the 2 options "Show checkouts to guarantors" and "Show fines to guarantors" are displayed Select Yes, save Confirm that the values have been correctly saved Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> QA script ok, test plan ok, code ok :) Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.01 Pushed to 20.05.x for 20.05.07 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |