| Summary: | Reindent batch item modification template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 26960 | ||
| Attachments: |
Bug 26959: Reindent batch item modification template
Bug 26959: (follow-up) Add markup comments Bug 26959: Reindent batch item modification template Bug 26959: (follow-up) Add markup comments Bug 26959: Reindent batch item modification template Bug 26959: (follow-up) Add markup comments Bug 26959: Reindent batch item modification template Bug 26959: (follow-up) Add markup comments Bug 26959: (follow-up) Fix CSS for column selection labels |
||
|
Description
Owen Leonard
2020-11-06 16:58:47 UTC
Created attachment 113263 [details] [review] Bug 26959: Reindent batch item modification template This patch reindents the batch item modification template to make indentation consistent. Some lines have been split up. Some markup issues have been corrected: Removed script "type" attribute, removed obsolete "CDATA" markers, removed obsolete IE-specific conditional comment. To test, apply the patch and go to Tools -> Batch item modification. - Test the process of submitting a barcode file, and item number file, and a list of barcodes. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I've been known to leave my car keys in the refrigerator from time to time. The only changes you see should be split lines. Created attachment 113264 [details] [review] Bug 26959: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 116264 [details] [review] Bug 26959: Reindent batch item modification template This patch reindents the batch item modification template to make indentation consistent. Some lines have been split up. Some markup issues have been corrected: Removed script "type" attribute, removed obsolete "CDATA" markers, removed obsolete IE-specific conditional comment. To test, apply the patch and go to Tools -> Batch item modification. - Test the process of submitting a barcode file, and item number file, and a list of barcodes. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I've been known to leave my car keys in the refrigerator from time to time. The only changes you see should be split lines. Created attachment 116265 [details] [review] Bug 26959: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 117286 [details] [review] Bug 26959: Reindent batch item modification template This patch reindents the batch item modification template to make indentation consistent. Some lines have been split up. Some markup issues have been corrected: Removed script "type" attribute, removed obsolete "CDATA" markers, removed obsolete IE-specific conditional comment. To test, apply the patch and go to Tools -> Batch item modification. - Test the process of submitting a barcode file, and item number file, and a list of barcodes. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I've been known to leave my car keys in the refrigerator from time to time. The only changes you see should be split lines. Signed-off-by: David Nind <david@davidnind.com> Created attachment 117287 [details] [review] Bug 26959: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Created attachment 117415 [details] [review] Bug 26959: Reindent batch item modification template This patch reindents the batch item modification template to make indentation consistent. Some lines have been split up. Some markup issues have been corrected: Removed script "type" attribute, removed obsolete "CDATA" markers, removed obsolete IE-specific conditional comment. To test, apply the patch and go to Tools -> Batch item modification. - Test the process of submitting a barcode file, and item number file, and a list of barcodes. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I've been known to leave my car keys in the refrigerator from time to time. The only changes you see should be split lines. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 117416 [details] [review] Bug 26959: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> It's not a problem with this patch set, but I see probems with the batch item edit process. I am trying to change less than 20 items and it won't finish :( (In reply to Katrin Fischer from comment #9) > It's not a problem with this patch set, but I see probems with the batch > item edit process. I am trying to change less than 20 items and it won't > finish :( With a different set of items it works with and without the patch - not enough to report here. The span in the columns selection can be split on 2 lines: https://snipboard.io/NZ7IdA.jpg vs https://snipboard.io/4Wh0RO.jpg Created attachment 117622 [details] [review] Bug 26959: (follow-up) Fix CSS for column selection labels This patch modifies the staff interface SCSS in order to fix the display of column selection checkbox labels on the batch item modification page. Even though the style of the elements defines the "white-space" as "nowrap," adding whitespace within the element (as was done to correct indentation) still created problems. Changing the display property of the elements to "inline-block" corrects this. Current status: Failed QA (In reply to Owen Leonard from comment #12) > Current status: Failed QA Sorry, git-bz mistake (In reply to Owen Leonard from comment #12) > Created attachment 117622 [details] [review] [review] > Bug 26959: (follow-up) Fix CSS for column selection labels Thanks! Sorry for being picky! :) Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |
