Summary: | Move batch item modification template JavaScript to the footer | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.05.00
|
Circulation function: | |
Bug Depends on: | 26959 | ||
Bug Blocks: | |||
Attachments: |
Bug 26960: Move batch item modification template JavaScript to the footer
Bug 26960: Move batch item modification template JavaScript to the footer Bug 26960: Move batch item modification template JavaScript to the footer Bug 26960: Move batch item modification template JavaScript to the footer |
Description
Owen Leonard
2020-11-06 18:36:53 UTC
Created attachment 113280 [details] [review] Bug 26960: Move batch item modification template JavaScript to the footer This patch modifies the batch item modification template so that the JavaScript is in the footer, conforming with best practices. The items form can contain <script> tags injected by cataloging plugins. These are moved from the body of the page into the footer be repeating the template loop that previously output the script tag. To test, apply the patch and test the process of submitting items for batch modification. After submitting a batch of items, test the "Edit items" form. Confirm that JavaScript-dependent interactions work correctly: - Select2-styled dropdowns - RegEx checkboxes - Datepicker - Plugins like: - dateaccessioned.pl on 952d - stocknumberam123.pl on 952i - callnumber.pl on 952o Created attachment 116266 [details] [review] Bug 26960: Move batch item modification template JavaScript to the footer This patch modifies the batch item modification template so that the JavaScript is in the footer, conforming with best practices. The items form can contain <script> tags injected by cataloging plugins. These are moved from the body of the page into the footer be repeating the template loop that previously output the script tag. To test, apply the patch and test the process of submitting items for batch modification. After submitting a batch of items, test the "Edit items" form. Confirm that JavaScript-dependent interactions work correctly: - Select2-styled dropdowns - RegEx checkboxes - Datepicker - Plugins like: - dateaccessioned.pl on 952d - stocknumberam123.pl on 952i - callnumber.pl on 952o Created attachment 117285 [details] [review] Bug 26960: Move batch item modification template JavaScript to the footer This patch modifies the batch item modification template so that the JavaScript is in the footer, conforming with best practices. The items form can contain <script> tags injected by cataloging plugins. These are moved from the body of the page into the footer be repeating the template loop that previously output the script tag. To test, apply the patch and test the process of submitting items for batch modification. After submitting a batch of items, test the "Edit items" form. Confirm that JavaScript-dependent interactions work correctly: - Select2-styled dropdowns - RegEx checkboxes - Datepicker - Plugins like: - dateaccessioned.pl on 952d - stocknumberam123.pl on 952i - callnumber.pl on 952o Signed-off-by: David Nind <david@davidnind.com> Created attachment 117417 [details] [review] Bug 26960: Move batch item modification template JavaScript to the footer This patch modifies the batch item modification template so that the JavaScript is in the footer, conforming with best practices. The items form can contain <script> tags injected by cataloging plugins. These are moved from the body of the page into the footer be repeating the template loop that previously output the script tag. To test, apply the patch and test the process of submitting items for batch modification. After submitting a batch of items, test the "Edit items" form. Confirm that JavaScript-dependent interactions work correctly: - Select2-styled dropdowns - RegEx checkboxes - Datepicker - Plugins like: - dateaccessioned.pl on 952d - stocknumberam123.pl on 952i - callnumber.pl on 952o Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This works well in my tests. There is only one small glitch: with and without the patch the pull down for the Yes/No for local holds priority is too short to fit the text. Not relevant for this patch. Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |