| Summary: | Koha notice/slips/receipts should print in true black (#000000) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Label/patron card printing | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | alexanderchen530+kohabugzilla, andrew, caroline.cyr-la-rose, dcook, fridolin.somers, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
Almost black color in CSS rules (like #000066) are now replaced by true black color #000000
|
Version(s) released in: |
21.05.00,20.11.02
|
| Circulation function: | |||
| Attachments: |
Bug 26962: Make print.css pure black
Bug 26962: Make print.css pure black Bug 26962: Make print.css pure black Bug 26962: (follow-up) Catch other #000066 occurrences |
||
|
Description
Lucas Gass (lukeg)
2020-11-06 22:31:28 UTC
Just to add some info here for reference. The issue doesn't affect normal printing on letter sized paper on regular laser/ink printers, but on thermal POS printers it becomes like a fuzzy dotted print. Our printers are Star TSP100 series. Created attachment 113281 [details] [review] Bug 26962: Make print.css pure black Test plan: 1. Generate some different notice/slips like ISSUESLIP, HOLD_SLIP, any slip you like 2. Inspect and see that body, p tags and see that the computed color is #333333 or #000066. 3. Apply patch 4. The computed style for color should not be #00000 5. This prints much better, especially on thermal/receipt printers Created attachment 113336 [details] [review] Bug 26962: Make print.css pure black Test plan: 1. Generate some different notice/slips like ISSUESLIP, HOLD_SLIP, any slip you like 2. Inspect and see that body, p tags and see that the computed color is #333333 or #000066. 3. Apply patch 4. The computed style for color should not be #00000 5. This prints much better, especially on thermal/receipt printers Signed-off-by: David Cook <dcook@prosentient.com.au> I could not find a way to follow the test plan in Chrome due to the Chrome print pop-up, but visually it looked good. Just for documentation purposes I'm posting the original solution I found on StackOverflow and sent a ticket to ByWater: https://stackoverflow.com/questions/27203571/receipt-printing-in-chrome-bad-quality The original StackOverflow thread was in a different environment but he is using the same printer and the same receipt paper we have. Thanks Lucas for making the solution work in Koha~ :) Lucas/David - after this is all finished in Koha proper instead of using "@media print", I can test it on real receipt printers for you guys (actually I already tested while Lucas and I were playing around with it, it looks good with #000000). Also a small thing that David's mentioning of Chrome pop-up reminded me to write this down too: we use Chrome's --kioskprinting" switch to bypass the "select a printer" pop-up and shoot out the receipts directly. Thanks. Great additional context, Alex! Created attachment 114996 [details] [review] Bug 26962: Make print.css pure black Test plan: 1. Generate some different notice/slips like ISSUESLIP, HOLD_SLIP, any slip you like 2. Inspect and see that body, p tags and see that the computed color is #333333 or #000066. 3. Apply patch 4. The computed style for color should not be #00000 5. This prints much better, especially on thermal/receipt printers Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Why not the other occurrences? % git grep -l -c 000066 At least those 3 seem relevant: koha-tmpl/intranet-tmpl/prog/css/print.css koha-tmpl/intranet-tmpl/prog/css/printreceiptinvoice.css koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss No idea about: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt (In reply to Jonathan Druart from comment #8) > Why not the other occurrences? > > % git grep -l -c 000066 > > At least those 3 seem relevant: > koha-tmpl/intranet-tmpl/prog/css/print.css > koha-tmpl/intranet-tmpl/prog/css/printreceiptinvoice.css > koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss > > No idea about: > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt Good point, I will submit a follow up. Created attachment 115104 [details] [review] Bug 26962: (follow-up) Catch other #000066 occurrences Addtional test steps: -Check printing an invoice, inscept the page and make sure none of the colors are set to #000066 -For the OPAC you must rebuild the CSS ((https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) -Look at some areas where you might print in the OPAC (try a list), inscept the page and make sure there is no colors set to #000066 -You can also use Jonathan's method of 'git grep -l -c 000066' to make sure no occurrences are left. -I left macles.tt as is because I am not sure about that template Pushed to master for 21.05, thanks to everybody involved! Small enhancement applies on 20.11, I choose to backport. Pushed to 20.11.x for 20.11.02 Enhancement, not backporting to 20.05. Please ask if needed! |