|
Description
Owen Leonard
2020-11-09 12:54:22 UTC
Created attachment 113312 [details] [review] Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. Created attachment 113313 [details] [review] Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 116267 [details] [review] Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. Created attachment 116268 [details] [review] Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Verified that everything else still works, but bug 27737 makes it impossible to test the authority search plugin behavior. And of course, fixing bug 27737 caused this patch to no longer apply. Created attachment 129279 [details] [review] Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. Created attachment 129280 [details] [review] Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 129965 [details] [review] Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. Signed-off-by: David Nind <david@davidnind.com> Created attachment 129966 [details] [review] Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=26975 Signed-off-by: David Nind <david@davidnind.com> Created attachment 130636 [details] [review] Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. Signed-off-by: David Nind <david@davidnind.com> Created attachment 130637 [details] [review] Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=26975 Signed-off-by: David Nind <david@davidnind.com> Created attachment 130928 [details] [review] k Created attachment 130929 [details] [review] Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 130930 [details] [review] Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=26975 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 131052 [details] [review] Bug 26975: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=26975 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |