Summary: | No property notforloan for Koha::Serial::Item | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Serials | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | aleisha, colin.campbell, jonathan.druart, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.06
|
|
Circulation function: | |||
Bug Depends on: | 23463 | ||
Bug Blocks: | |||
Attachments: |
Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable
Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable |
Description
Magnus Enger
2020-11-10 13:09:32 UTC
Coming from commit bbb504c86f5ca0a474365d4839177412f415c4ee Bug 23463: Replace ModItem with Koha::Item->store Created attachment 113394 [details] [review] Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable $serialitem is not a Koha::Item there, we need to fetch the item before. Test plan: Turn makePreviousSerialAvailable on Create a subscription Receive an serial item, mark it "arrived" Without this patch Koha explodes with No property notforloan for Koha::Serial::Item at /usr/share/perl5/Exception/Class/Base.pm line 88 Koha::Object::set('Koha::Serial::Item=HASH(0x55dd67c75700)', 'HASH(0x55dd672cec30)') called at /kohadevbox/koha/serials/serials-edit.pl line 273 With this patch applied the notforloan and itype values are correctly set for the new serial item. Created attachment 113397 [details] [review] Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable $serialitem is not a Koha::Item there, we need to fetch the item before. Test plan: Turn makePreviousSerialAvailable on Create a subscription Receive an serial item, mark it "arrived" Without this patch Koha explodes with No property notforloan for Koha::Serial::Item at /usr/share/perl5/Exception/Class/Base.pm line 88 Koha::Object::set('Koha::Serial::Item=HASH(0x55dd67c75700)', 'HASH(0x55dd672cec30)') called at /kohadevbox/koha/serials/serials-edit.pl line 273 With this patch applied the notforloan and itype values are correctly set for the new serial item. Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch on a live server showing the described problem, and the problem was fixed, Koha does not explode. I think this warrants blocker status - can't receive items for serials while this is not fixed in 20.05.x Created attachment 113496 [details] [review] Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable $serialitem is not a Koha::Item there, we need to fetch the item before. Test plan: Turn makePreviousSerialAvailable on Create a subscription Receive an serial item, mark it "arrived" Without this patch Koha explodes with No property notforloan for Koha::Serial::Item at /usr/share/perl5/Exception/Class/Base.pm line 88 Koha::Object::set('Koha::Serial::Item=HASH(0x55dd67c75700)', 'HASH(0x55dd672cec30)') called at /kohadevbox/koha/serials/serials-edit.pl line 273 With this patch applied the notforloan and itype values are correctly set for the new serial item. Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch, works as expected after patch, no regressions found. Passing QA Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.06 missing dependencies, not backported to 19.11.x |