Summary: | Add further defensive coding to EDI Invoice handling | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Acquisitions | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Attachments: |
Patch adding log entries
Bug 27017: Code more defensively in process_invoice Bug 27017: Code more defensively in process_invoice Bug 27017: (QA follow-up) Don't die if aqorders.biblionumber is null |
Description
Colin Campbell
2020-11-13 13:45:08 UTC
Created attachment 113604 [details] [review] Patch adding log entries Patch adds two log entries one if no order match one to record bib if processing ok. If no match code jumps to next line to avoid possible runtime errors further down. Recording this info in the the edi log has proved very useful. Hi Colin. The patch still applies. I'm not familiar with EDI, but I am happy to test if you could include a test plan on how to set this up for testing. Also, the QA Team might ask you to fix up the commit message for the patch - see https://wiki.koha-community.org/wiki/Commit_messages I've updated assignee to Martin for now - afaik Colin is retired :) Thanks Katrin! Created attachment 142714 [details] [review] Bug 27017: Code more defensively in process_invoice This patch adds a check for ordernumber precence in the EDI Invoice message lines and skips process if one is not found. We log the failure as a trace log to allow administrators the oportunity to track down the issue further. We also add a trace log to entries to show which bib the invoice line is receipting to. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I've raised this one with Kyle for a QA run.. EDI is always hard to test.. but the code is pretty simple to read and understand here so hopefully we can get it moving without too much pain. Created attachment 142726 [details] [review] Bug 27017: Code more defensively in process_invoice This patch adds a check for ordernumber precence in the EDI Invoice message lines and skips process if one is not found. We log the failure as a trace log to allow administrators the oportunity to track down the issue further. We also add a trace log to entries to show which bib the invoice line is receipting to. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 142730 [details] [review] Bug 27017: (QA follow-up) Don't die if aqorders.biblionumber is null Pushed to master for 22.11. Nice work everyone, thanks! |