Summary: | Add class names in the suggestions column in suggestions management | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass <lucas> |
Component: | Acquisitions | Assignee: | Lucas Gass <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | andrewfh, caroline.cyr-la-rose, fridolin.somers, jonathan.druart, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement adds classes to the various information spans displayed in the suggestions table. This allows for simple targeting of CSS rules to highlight or hide information that is important/irrelevant for your library's use.
|
Version(s) released in: |
21.05.00,20.11.03
|
Attachments: |
Bug 27023: Add class names in acq suggestion table (suggestions column)
Bug 27023: Add class names in acq suggestion table (suggestions column) Bug 27023: Add class names in acq suggestion table (suggestions column) Bug 27023: (QA follow-up) Fix span tags Bug 27023: Add class names in acq suggestion table (suggestions column) Bug 27023: Add class names in acq suggestion table (suggestions column) Bug 27023: (QA follow-up) Fix span tags Bug 27023: Add class names in acq suggestion table (suggestions column) Bug 27023: (QA follow-up) Fix span tags |
Description
Lucas Gass
2020-11-13 23:00:20 UTC
Created attachment 113635 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Created attachment 113640 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com> Created attachment 114994 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com> Created attachment 114995 [details] [review] Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it) Typo suggestion_coprightdate Created attachment 115209 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com> Hi Lucas, did you see my follow-up patch? Sequence of attachements is wrong now, but not sure if you tested with or without. Created attachment 115213 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com> Created attachment 115214 [details] [review] Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it) (In reply to Katrin Fischer from comment #7) > Hi Lucas, did you see my follow-up patch? Sequence of attachements is wrong > now, but not sure if you tested with or without. Sorry about that. I have tested with your QA follow-up. I the reattached them in the correct order. I am still keeping David's SO line. Created attachment 115220 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 115221 [details] [review] Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it) Move spaces around a bit so the strings don't start with spaces. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Small enhancement, I choose to backport. Pushed to 20.11.x for 20.11.03 Enhancement, not backporting to 20.05. Please ask if needed. |