| Summary: | Typo: has successfully been modified.. %s | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Amy King <amyking386> |
| Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | amyking386, andrew, caroline.cyr-la-rose, david, fridolin.somers, jonathan.druart, nick |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes a grammatical error in koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt (has successfully been modified..) - it replaces two full stops at the end of the sentence with one.
|
Version(s) released in: |
21.05.00,20.11.03
|
| Circulation function: | |||
| Bug Depends on: | 22417 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 27027 Type in line 125 corrected
Bug: 27027 Fixed typo, line 125, removed extra dot. Bug 27027: Fixed typo - extra dot removed Bug 27027: Fixed typo - extra dot removed Bug 27027: Fixed typo - extra dot removed |
||
|
Description
Katrin Fischer
2020-11-14 11:45:19 UTC
koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt 125 Authority record <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% m.authid | uri %]">[% m.authid | html %]</a> has successfully been modified.. Created attachment 115281 [details] [review] Bug 27027 Type in line 125 corrected Test Plan Before applying patch 1. Open koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt 2. Note how in line 125 "has successfully been modified.." has two full stops 3. Apply patch 4. Repeat step 1 5. Note how there is only now one full stop in line 125 "has been successfully ben modified." Hello Amy, can you resubmit your patch with the commit message starting with "Bug 27027: ". Also take a look at this wiki page: https://wiki.koha-community.org/wiki/Commit_messages#Examples The commit message must tell what the patch does. Like "Fix typo - remove extra dot" or something in the line. Created attachment 115348 [details] [review] Bug: 27027 Fixed typo, line 125, removed extra dot. Test Plan Before applying patch 1. Open koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt 2. Note how in line 125 "has successfully been modified.." has two full stops 3. Apply patch 4. Repeat step 1 5. Note how there is only now one full stop in line 125 "has been successfully ben modified." Created attachment 115349 [details] [review] Bug 27027: Fixed typo - extra dot removed Test Plan Before applying patch 1. Open koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt 2. Note how in line 125 "has successfully been modified.." has two full stops 3. Apply patch 4. Repeat step 1 5. Note how there is only now one full stop in line 125 "has been successfully ben modified." Created attachment 115451 [details] [review] Bug 27027: Fixed typo - extra dot removed Test Plan Before applying patch 1. Open koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt 2. Note how in line 125 "has successfully been modified.." has two full stops 3. Apply patch 4. Repeat step 1 5. Note how there is only now one full stop in line 125 "has been successfully ben modified." Signed-off-by: David Nind <david@davidnind.com> Thanks Amy! Created attachment 115578 [details] [review] Bug 27027: Fixed typo - extra dot removed Test Plan Before applying patch 1. Open koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt 2. Note how in line 125 "has successfully been modified.." has two full stops 3. Apply patch 4. Repeat step 1 5. Note how there is only now one full stop in line 125 "has been successfully ben modified." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.03 Missing dependencies, not backported to 20.05 |