Bug 27028

Summary: Manual transfers: patron name display in hold warning should be standardized
Product: Koha Reporter: Victor Grousset/tuxayo <victor>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25682
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: screenshot-of-the-issue

Description Victor Grousset/tuxayo 2020-11-14 12:32:06 UTC
Created attachment 113641 [details]
screenshot-of-the-issue

== Test plan ==
1. Place a hold (record level in my example)
2. Try a transfer
3. Get a hold warning
4. It doesn't display (at least, not checked everything) the patron's name and their branch. See screenshot-of-the-issue.png 



The code confirms that it should:

Reserve found for [% name | html %] (<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber | uri %]">[% borrowernumber | html %]</a>).

[...]

[% IF ( reserved ) %]Set reserve to waiting and transfer book to [% branchname | html %]: [% END %]
Comment 1 Katrin Fischer 2023-01-26 23:33:19 UTC
The display could be a little nicer, but it works now:

Hold found for koha (42) (51). 

42 = cardnumber
51 = linked borrowernumber

... and the heading still reads Reserve found, this should be Hold found.

I am updating the bug description a little, we should use a standardized patron name display here, that also respects visibility settings etc.
Comment 2 Owen Leonard 2024-04-24 14:59:25 UTC
I'm working on a patch for Bug 25682 which I think will solve this issue.