Summary: | Deprecate core support for PayPal payments | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Fines and fees | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, andrewfh, jonathan.druart, katrin.fischer, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
Bug Depends on: | 23118 | ||
Bug Blocks: | 23215 | ||
Attachments: |
Bug 27044: Mark the PayPal integration as deprecated on the user interface
Bug 27044: Mark the PayPal integration as deprecated on the user interface Bug 27044: Mark the PayPal integration as deprecated on the user interface Bug 27044: Mark the PayPal integration as deprecated on the user interface |
Description
Tomás Cohen Arazi
2020-11-17 17:17:14 UTC
Things to do for 20.11: - Deprecate the PayPal payments module in the release notes - Add information about deprecation to the Paypal system preferences - Add an entry to the "system information" tab Does this read correctly? diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index ccbd533b19e..85e4c5290b8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ -901,6 +901,7 @@ OPAC: yes: "sandbox" no: "production" - "mode." + - "<br/>Warning: this functionality has been deprecated in favour of plugin implementations." - - "The email address to receive PayPal payments is " - pref: PayPalUser Created attachment 113750 [details] [review] Bug 27044: Mark the PayPal integration as deprecated on the user interface Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Maybe: in favor of using payment plugins that can implement different payment services. ? Created attachment 113806 [details] [review] Bug 27044: Mark the PayPal integration as deprecated on the user interface Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 113843 [details] [review] Bug 27044: Mark the PayPal integration as deprecated on the user interface Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works as expected, the syspref has the warning and about.pl adds a warning if the syspref is enabled. Why are not you using Koha.Preference from TT? Do we need it in 20.11.00 even if there is a string change? (I think so) (In reply to Jonathan Druart from comment #8) > Why are not you using Koha.Preference from TT? It is how that page is usually built. I'm not attached to it. > Do we need it in 20.11.00 even if there is a string change? (I think so) I'd say it should be included. Created attachment 113949 [details] [review] Bug 27044: Mark the PayPal integration as deprecated on the user interface Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 20.11, thanks to everybody involved! Not backporting to 20.05, request if needed |