Summary: | Don't process staff interface CSS with rtlcss | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Architecture, internals, and plumbing | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, jonathan.druart, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
Circulation function: | |||
Bug Depends on: | 20168 | ||
Bug Blocks: | |||
Attachments: |
Bug 27072: Don't process staff interface CSS with rtlcss
Bug 27072: Don't process staff interface CSS with rtlcss Bug 27072: Don't process staff interface CSS with rtlcss Bug 27072: Don't process staff interface CSS with rtlcss |
Description
Owen Leonard
2020-11-20 20:13:17 UTC
I'd like this one for 20.11 if possible. Created attachment 113925 [details] [review] Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. Created attachment 113938 [details] [review] Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. Signed-off-by: David Nind <david@davidnind.com> Created attachment 113950 [details] [review] Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Thank, Owen! Created attachment 113951 [details] [review] Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Ohh, we clashed.. I was just QAing too.. double signoff :) Pushed to master for 20.11, thanks to everybody involved! Missing dependency, not backported to 20.05 |