Summary: | Notes missing from lost items report column configuration when CSV export is active | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Attachments: |
Bug 27081: Handle first column (checkboxes) in column settings for lost items report
Bug 27081: Handle first column (checkboxes) in column settings for lost items report Bug 27081: Handle first column (checkboxes) in column settings for lost items report |
Description
Katrin Fischer
2020-11-23 16:25:52 UTC
Ok on master. Thx for checking! This is ok in 21.05 as well, but in 20.11.06 the last entry in the pull down is 'not for loan', notes is missing there. I figured it out: The problem is only visible when a CSV profile for the lost items report has been defined. When you do this an additional first row with checkboxes appears that sets the column configuration off by one and the "notes" disappear as last option from the columns list. Still valid on master. To test: * Create a CSV profile of type SQL for exporting lost items * Make sure you have some lost items * Run Reports > Items lost * Verify the list of columns ends with 'not for loan status', note is missing Created attachment 139001 [details] [review] Bug 27081: Handle first column (checkboxes) in column settings for lost items report We are adding one column (the one with the checkboxes) at the beginning of each row if it's possible to export the report to CSV. However the column settings were not modified. We need to append one object representing this column. Test plan: To test: * Create a CSV profile of type SQL for exporting lost items * Make sure you have some lost items * Run Reports > Items lost => You can hide the notes (last column) Sorry, I didn't test correctly. This patch should fix the problem. I hadn't noticed we overlapped, Andrew. Reattaching with your stamp! Created attachment 139561 [details] [review] Bug 27081: Handle first column (checkboxes) in column settings for lost items report We are adding one column (the one with the checkboxes) at the beginning of each row if it's possible to export the report to CSV. However the column settings were not modified. We need to append one object representing this column. Test plan: To test: * Create a CSV profile of type SQL for exporting lost items * Make sure you have some lost items * Run Reports > Items lost => You can hide the notes (last column) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 140161 [details] [review] Bug 27081: Handle first column (checkboxes) in column settings for lost items report We are adding one column (the one with the checkboxes) at the beginning of each row if it's possible to export the report to CSV. However the column settings were not modified. We need to append one object representing this column. Test plan: To test: * Create a CSV profile of type SQL for exporting lost items * Make sure you have some lost items * Run Reports > Items lost => You can hide the notes (last column) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! Cannot recreate in 22.05.x, no backport |