Summary: | Corrections in overdue_notices.pl help text | ||
---|---|---|---|
Product: | Koha | Reporter: | Timothy Alexis Vass <timothy_alexis.vass> |
Component: | Command-line Utilities | Assignee: | Timothy Alexis Vass <timothy_alexis.vass> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | andrew, caroline.cyr-la-rose, fridolin.somers, jonathan.druart, robin, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.05.00,20.11.02,20.05.08,19.11.14
|
Circulation function: | |
Bug Depends on: | 2274 | ||
Bug Blocks: | |||
Attachments: |
Bug 27085 - Corrections in overdue_notices.pl help text
Bug 27085: Corrections in overdue_notices.pl help text Bug 27085: Corrections in overdue_notices.pl help text |
Description
Timothy Alexis Vass
2020-11-24 12:27:42 UTC
Help text should also be proper sentences. Created attachment 113970 [details] [review] Bug 27085 - Corrections in overdue_notices.pl help text -library <branchname> only deal with overdues from this library (repeatable : several libraries can be given) Should be <branchcode> Help text should also be proper sentences. To test: 0) Run misc/cronjobs/overdue_notices.pl -h 1) Check that the text is now: -library <branchcode> Only deal with overdues from this library. 2) Check that the rest of the help text are proper sentences, with leading capital letter and punctuation. 3) Sign off. Sponsored-by: Lunds Universitetsbibliotek Created attachment 114442 [details] [review] Bug 27085: Corrections in overdue_notices.pl help text -library <branchname> only deal with overdues from this library (repeatable : several libraries can be given) Should be <branchcode> Help text should also be proper sentences. To test: 0) Run misc/cronjobs/overdue_notices.pl -h 1) Check that the text is now: -library <branchcode> Only deal with overdues from this library. 2) Check that the rest of the help text are proper sentences, with leading capital letter and punctuation. 3) Sign off. Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Fix makes sens. I corrected the commit message, see https://wiki.koha-community.org/wiki/Commit_messages Created attachment 114680 [details] [review] Bug 27085: Corrections in overdue_notices.pl help text -library <branchname> only deal with overdues from this library (repeatable : several libraries can be given) Should be <branchcode> Help text should also be proper sentences. To test: 0) Run misc/cronjobs/overdue_notices.pl -h 1) Check that the text is now: -library <branchcode> Only deal with overdues from this library. 2) Check that the rest of the help text are proper sentences, with leading capital letter and punctuation. 3) Sign off. Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.02 Pushed to 20.05.x for 20.05.08 Backported: Pushed to 19.11.x branch for 19.11.14 |