Summary: | In the location column of an OPAC cart the 'In transit from' and 'to' fields are empty | ||
---|---|---|---|
Product: | Koha | Reporter: | Christophe Croullebois <christophe.croullebois> |
Component: | OPAC | Assignee: | Christophe Croullebois <christophe.croullebois> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, caroline.cyr-la-rose, christophe.croullebois, fridolin.somers, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.02,20.05.08,19.11.14
|
|
Circulation function: | |||
Attachments: |
in an Opac basket enables the 'In transit from' and 'to' fields to be displayed
Bug 26051: Elasticsearch field local-classification sort=1 in mapping.yaml Bug 27090: Opac basket: fix the 'In transit from' and 'to' Bug 27090: Opac basket: fix the 'In transit from' and 'to' |
Description
Christophe Croullebois
2020-11-25 10:18:35 UTC
Created attachment 113971 [details] [review] in an Opac basket enables the 'In transit from' and 'to' fields to be displayed To see the 'In transit from' and 'to' fields in an Opac basket we have : <span class="item-status intransit">In transit from [% Branches.GetName( item.transfertfrom ) | html %] to [% Branches.GetName( item.transfertto ) | html %] since [% item.transfertwhen | $KohaDates %]</span> But in koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc we have no : [% USE Branches %] This patch just corrects this lack Thx To test : 1° find an item in a transit status or create one with this status 2° put it in an Opac basket 3° note that in the location column of the Opac basket the 'In transit from' and 'to' fields are empty. 4° apply the patch 5° check again and validate that the 2 fields are now filled Thx Created attachment 114708 [details] [review] Bug 26051: Elasticsearch field local-classification sort=1 in mapping.yaml With Elasticsearch the search field use for sorting by callnumber is "local-classification" (from Koha::SearchEngine::Elasticsearch::QueryBuilder::_convert_sort_fields). So this search field must be sortable in default mappings.yaml. If not you see this error in logs : No mapping found for [local-classification__sort] Test plan : 1) Install Koha with Elasticsearch with mappings.yaml from sources (admin/searchengine/elasticsearch/mappings.yaml) It should be the case on all developement instalations 2) Reset mappings (Administration › Search engine configuration (Elasticsearch)) 3) Rebuild indexes: misc/search_tools/rebuild_elasticsearch.pl -v -d 4) Perform a search 5) Check sorting by callnumber is OK (add some call numbers if necessary) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 114709 [details] [review] Bug 27090: Opac basket: fix the 'In transit from' and 'to' To see the 'In transit from' and 'to' fields in an Opac basket we have : <span class="item-status intransit">In transit from [% Branches.GetName( item.transfertfrom ) | html %] to [% Branches.GetName( item.transfertto ) | html %] since [% item.transfertwhen | $KohaDates %]</span> But in koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc we have no : [% USE Branches %] This patch just corrects this lack Test plan: 1° find an item in a transit status or create one with this status 2° put it in an Opac basket 3° note that in the location column of the Opac basket the 'In transit from' and 'to' fields are empty. 4° apply the patch 5° check again and validate that the 2 fields are now filled Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Oops, attached an additional patch that was from another ticket. Thanks, it works as expected :) Fixed the commit message to include the description of the fix and test plan. (I just copied comment 1 and comment 2) And made the first line of the commit message shorter to be in git recommendations (70 chars max) Created attachment 114967 [details] [review] Bug 27090: Opac basket: fix the 'In transit from' and 'to' To see the 'In transit from' and 'to' fields in an Opac basket we have : <span class="item-status intransit">In transit from [% Branches.GetName( item.transfertfrom ) | html %] to [% Branches.GetName( item.transfertto ) | html %] since [% item.transfertwhen | $KohaDates %]</span> But in koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc we have no : [% USE Branches %] This patch just corrects this lack Test plan: 1° find an item in a transit status or create one with this status 2° put it in an Opac basket 3° note that in the location column of the Opac basket the 'In transit from' and 'to' fields are empty. 4° apply the patch 5° check again and validate that the 2 fields are now filled Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.02 Pushed to 20.05.x for 20.05.08 Backported: Pushed to 19.11.x branch for 19.11.14 |