| Summary: | Adding a hold cancellation reason should not always send a notice | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Notices | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | blocker | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 12656, 25534 | ||
| Bug Blocks: | 26282 | ||
| Attachments: |
Bug 27103: Remove HOLD_CANCELLATION notice
Bug 27103: Remove HOLD_CANCELLATION notice Bug 27103: Remove from fr-FR |
||
|
Description
Martin Renvoize (ashimema)
2020-11-27 10:21:49 UTC
Given the time of the cycle, we decided to do a quick fix for bug 26282 to avoid string changes and do the work properly for the 20.11.01 release. This bug will simply remove the sample notice to disable the notices part of the cancellation reason enhancement. Created attachment 114036 [details] [review] Bug 27103: Remove HOLD_CANCELLATION notice We are really close to release, and the 'proper' fix to make the sending of hold cancellation notices optional will introduce string changes. This patch takes the alternative approach of removing the default notice template there by disabling the feature for 20.11.00 release and giving us time to properly impliment a solution and re-instate the default notice template for the 20.11.01 release. Test plan 1/ Run through a fresh install 2/ Note that there is no 'HOLD_CANCELLATION' notice added 3/ Place a hold 4/ Cancel the hold (giving a reason) 5/ Note that no notice is queud for the patron 6/ Bonus points: Note that a warning appears for the missing notice template in the system logs. Descriptions and release note texts for bug 12656 and bug 25534 have been updated to reflect the change here. Setting to Signed off to get immediate attention of the QA team (this is a blocker for today's release and is an alternative to the full treatment in bug 26282) Created attachment 114038 [details] [review] Bug 27103: Remove HOLD_CANCELLATION notice We are really close to release, and the 'proper' fix to make the sending of hold cancellation notices optional will introduce string changes. This patch takes the alternative approach of removing the default notice template there by disabling the feature for 20.11.00 release and giving us time to properly impliment a solution and re-instate the default notice template for the 20.11.01 release. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 114039 [details] [review] Bug 27103: Remove from fr-FR Pushed to master for 20.11, thanks to everybody involved! Missing dependencies, not backported to 20.05 |