|
Description
Tomás Cohen Arazi (tcohen)
2020-11-27 15:28:40 UTC
Created attachment 114074 [details] [review] Bug 27109: Remove Replay action - not implemented Created attachment 114075 [details] [review] Bug 27109: Improve labels on the background job views Replace "enqueued_on" with "Enqueued on", same for started_on and ended_on Created attachment 114464 [details] [review] Bug 27109: Remove Replay action - not implemented Signed-off-by: David Nind <david@davidnind.com> Created attachment 114465 [details] [review] Bug 27109: Improve labels on the background job views Replace "enqueued_on" with "Enqueued on", same for started_on and ended_on Signed-off-by: David Nind <david@davidnind.com> Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid English word, according to Oxford English Dictionary (https://www.lexico.com/definition/enqueue). However, it is not something in common usage or that I have come across before except in Koha. As this one improves the display, I've signed it off. I will add a new bug for changing the term and see what others think. Testing notes: - Applied patch: applied successfully - Reviewed diff, makes sense to me (In reply to David Nind from comment #5) > Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid > English word, according to Oxford English Dictionary > (https://www.lexico.com/definition/enqueue). However, it is not something in > common usage or that I have come across before except in Koha. As this one > improves the display, I've signed it off. I will add a new bug for changing > the term and see what others think. > > Testing notes: > - Applied patch: applied successfully > - Reviewed diff, makes sense to me I agree. Can you submit a follow-up on this bug for 'Queued'? Created attachment 114479 [details] [review] Bug 27109: Replace 'Enqueued' with 'Queuee' Thanks Tomás and Jonathan! (In reply to David Nind from comment #5) > Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid > English word, according to Oxford English Dictionary > (https://www.lexico.com/definition/enqueue). However, it is not something in > common usage or that I have come across before except in Koha. I love enqueue/dequeue and they come up a lot for me, but they do seem to be computing terms, so I am willing to admit that they probably should be reserved for backend systems and not displayed to users. I also love splitting hairs so... Should it be "Queued on" or "Queued at"? Last patch and discussion moved to bug 27277. This bug report is about making labels consistent, and they are with "Enqueued on" (it already exists and no additional work will be needed from translators). Created attachment 114969 [details] [review] Bug 27109: Remove Replay action - not implemented Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 114970 [details] [review] Bug 27109: Improve labels on the background job views Replace "enqueued_on" with "Enqueued on", same for started_on and ended_on Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.02 Missing dependency, not backported to 20.05. |