| Summary: | Show authority type for UNIMARC in authority search result display | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Cataloging | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.06
|
|
| Circulation function: | |||
| Bug Depends on: | 12533 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 27125: Show authority type also for UNIMARC in authority search result display
Bug 27125: Show authority type also for UNIMARC in authority search result display Bug 27125: Show authority type also for UNIMARC in authority search result display |
||
|
Description
Fridolin Somers
2020-12-01 13:26:22 UTC
Created attachment 114072 [details] [review] Bug 27125: Show authority type also for UNIMARC in authority search result display Bug 12533 added authority type in authority search result display. But it does not work for UNIMARC, due to : https://git.koha-community.org/Koha-community/Koha/src/commit/be9f64b638335cac7465ca302e187c7914534fbe/C4/AuthoritiesMarc.pm#L798 I propose to use result->{authtype} Test plan : 1) Use UNIMARC catalogue 2) Search for autorities 3) Check you see autority type in column 4) Same for a MARC21 catalogue Created attachment 117469 [details] [review] Bug 27125: Show authority type also for UNIMARC in authority search result display Bug 12533 added authority type in authority search result display. But it does not work for UNIMARC, due to : https://git.koha-community.org/Koha-community/Koha/src/commit/be9f64b638335cac7465ca302e187c7914534fbe/C4/AuthoritiesMarc.pm#L798 I propose to use result->{authtype} Test plan : 1) Use UNIMARC catalogue 2) Search for autorities 3) Check you see autority type in column 4) Same for a MARC21 catalogue Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> I followed the test plan, and the patch works as expected for both UNIMARC and MARC21. There is actually an improvement in the MARC21 case: previously, the 'Authority type' column for records in the Default framework would not display anything, whereas now it displays 'Default'. Created attachment 119732 [details] [review] Bug 27125: Show authority type also for UNIMARC in authority search result display Bug 12533 added authority type in authority search result display. But it does not work for UNIMARC, due to : https://git.koha-community.org/Koha-community/Koha/src/commit/be9f64b638335cac7465ca302e187c7914534fbe/C4/AuthoritiesMarc.pm#L798 I propose to use result->{authtype} Test plan : 1) Use UNIMARC catalogue 2) Search for autorities 3) Check you see autority type in column 4) Same for a MARC21 catalogue Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> I followed the test plan, and the patch works as expected for both UNIMARC and MARC21. There is actually an improvement in the MARC21 case: previously, the 'Authority type' column for records in the Default framework would not display anything, whereas now it displays 'Default'. Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.06 Missing dependency, not backported to 20.05 |