Summary: | Patron batch update from report module - no patrons loaded into view | ||
---|---|---|---|
Product: | Koha | Reporter: | Stefan Norinder <somesecretemail> |
Component: | Reports | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | andrew, david, fridolin.somers, jonathan.druart, kelly, marjorie.barry-vila, martin.renvoize, nick, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes an error when batch modifying patrons using the reports module. After running a report (such as SELECT * FROM borrowers LIMIT 50) and selecting batch modification an error was displayed: "Warning, the following cardnumbers were not found:", and you were not able to modify any patrons.
|
|
Version(s) released in: |
21.05.00,20.11.01, 20.05.07
|
Circulation function: | |
Bug Depends on: | 24886, 25942 | ||
Bug Blocks: | |||
Attachments: |
Bug 27142: Don't interpolate batch_type variable
Bug 27142: Don't interpolate batch_type variable Bug 27142: Don't interpolate batch_type variable |
Description
Stefan Norinder
2020-12-03 06:10:41 UTC
Created attachment 114146 [details] [review] Bug 27142: Don't interpolate batch_type variable To test: 1 - Create a report like: SELECT * FROM borrowers LIMIT 50 2 - Run the report 3 - Attempt batch modification - it fails showing every row as an unfound cardnumber 4 - Apply patch 5 - Repeat 6 - Success! 7 - Edit report to: SELECT * FROM biblio LIMIT 50 8 - Repeat test 9 - Ensure batch modification and deletion work Created attachment 114167 [details] [review] Bug 27142: Don't interpolate batch_type variable To test: 1 - Create a report like: SELECT * FROM borrowers LIMIT 50 2 - Run the report 3 - Attempt batch modification - it fails showing every row as an unfound cardnumber 4 - Apply patch 5 - Repeat 6 - Success! 7 - Edit report to: SELECT * FROM biblio LIMIT 50 8 - Repeat test 9 - Ensure batch modification and deletion work Signed-off-by: David Nind <david@davidnind.com> Created attachment 114238 [details] [review] Bug 27142: Don't interpolate batch_type variable To test: 1 - Create a report like: SELECT * FROM borrowers LIMIT 50 2 - Run the report 3 - Attempt batch modification - it fails showing every row as an unfound cardnumber 4 - Apply patch 5 - Repeat 6 - Success! 7 - Edit report to: SELECT * FROM biblio LIMIT 50 8 - Repeat test 9 - Ensure batch modification and deletion work Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected, no regressions found. Passing QA Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.01 Pushed to 20.05.x for 20.05.7 *** Bug 27194 has been marked as a duplicate of this bug. *** Missing dependencies for 19.11.x, can't backport. |