Description
Nick Clemens (kidclamp)
2020-12-03 16:56:55 UTC
Created attachment 114155 [details] [review] Bug 27149: Unit tests Created attachment 114156 [details] [review] Bug 27149: Don't strip itemnumber when adding item status via Z3950Responder To test: 1 - sudo koha-z3950-responder --stop kohadev 2 - Run it manually: perl /kohadevbox/koha/misc/z3950_responder.pl -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 3 - Connect and search to verify itemnumber is in item records yaz-client localhost:2100 base biblios find shuffle show 1+1 4 - sudo koha-z3950-responder --stop kohadev 5 - Run it manually to add item status perl /kohadevbox/koha/misc/z3950_responder.pl --add-item-status k -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 6 - Connect and search, no itemnumber in records 7 - Apply patch 8 - Stop, restart all the things, and manually start server with item status again 9 - Connect and search, itemnumbers are included Sorry Bug 27149: Unit tests does not apply on current master. Main patch works. I see no reason to strip itemnumber from item fields. Created attachment 114230 [details] [review] Bug 27149: Unit tests Created attachment 114231 [details] [review] Bug 27149: Don't strip itemnumber when adding item status via Z3950Responder To test: 1 - sudo koha-z3950-responder --stop kohadev 2 - Run it manually: perl /kohadevbox/koha/misc/z3950_responder.pl -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 3 - Connect and search to verify itemnumber is in item records yaz-client localhost:2100 base biblios find shuffle show 1+1 4 - sudo koha-z3950-responder --stop kohadev 5 - Run it manually to add item status perl /kohadevbox/koha/misc/z3950_responder.pl --add-item-status k -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 6 - Connect and search, no itemnumber in records 7 - Apply patch 8 - Stop, restart all the things, and manually start server with item status again 9 - Connect and search, itemnumbers are included Created attachment 114320 [details] [review] Bug 27149: Unit tests Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 114321 [details] [review] Bug 27149: Don't strip itemnumber when adding item status via Z3950Responder To test: 1 - sudo koha-z3950-responder --stop kohadev 2 - Run it manually: perl /kohadevbox/koha/misc/z3950_responder.pl -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 3 - Connect and search to verify itemnumber is in item records yaz-client localhost:2100 base biblios find shuffle show 1+1 4 - sudo koha-z3950-responder --stop kohadev 5 - Run it manually to add item status perl /kohadevbox/koha/misc/z3950_responder.pl --add-item-status k -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 6 - Connect and search, no itemnumber in records 7 - Apply patch 8 - Stop, restart all the things, and manually start server with item status again 9 - Connect and search, itemnumbers are included Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 115017 [details] [review] Bug 27149: Unit tests Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 115018 [details] [review] Bug 27149: Don't strip itemnumber when adding item status via Z3950Responder To test: 1 - sudo koha-z3950-responder --stop kohadev 2 - Run it manually: perl /kohadevbox/koha/misc/z3950_responder.pl -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 3 - Connect and search to verify itemnumber is in item records yaz-client localhost:2100 base biblios find shuffle show 1+1 4 - sudo koha-z3950-responder --stop kohadev 5 - Run it manually to add item status perl /kohadevbox/koha/misc/z3950_responder.pl --add-item-status k -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 6 - Connect and search, no itemnumber in records 7 - Apply patch 8 - Stop, restart all the things, and manually start server with item status again 9 - Connect and search, itemnumbers are included Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected.. Passing QA Created attachment 115063 [details] [review] Bug 27149: Don't strip itemnumber when adding item status via Z3950Responder This breaks MARCEdit integration as svc/bib uses the itemnumber field to update items To test: 1 - sudo koha-z3950-responder --stop kohadev 2 - Run it manually: perl /kohadevbox/koha/misc/z3950_responder.pl -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 3 - Connect and search to verify itemnumber is in item records yaz-client localhost:2100 base biblios find shuffle show 1+1 4 - sudo koha-z3950-responder --stop kohadev 5 - Run it manually to add item status perl /kohadevbox/koha/misc/z3950_responder.pl --add-item-status k -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 6 - Connect and search, no itemnumber in records 7 - Apply patch 8 - Stop, restart all the things, and manually start server with item status again 9 - Connect and search, itemnumbers are included Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.02 Pushed to 20.05.x for 20.05.08 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |