| Summary: | Show current class in plugins home | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Plugin architecture | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16391 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 |
||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | Bug 27188: Show current class in plugins home | ||
|
Description
Fridolin Somers
2020-12-10 09:47:59 UTC
Created attachment 114297 [details] [review] Bug 27188: Show current class in plugins home In plugins home, when searching on a specific class, you see the table but no reminder which class is displayed. Only when there are no results you see it in message. I propose to show it in H1 title and remove it from no results message. Sort of what is asked in Bug 16391. This change adds missing specific message to class 'ill_availability_services'. This change removed the message 'Unknown plugin type'. Seems useless to me since you must change manually method in URL to get it. And this may be usefull for unlisted classes like hooks 'opac_js', ... Test plan : 1) Enable plugins 2) Install a tool plugin like InLibro Carrousel 3) Go to Administration > Manage plugins 4) Check you see the plugin and title 'All plugins' 5) In menu select 'View tool plugins' 6) Check you see the plugin and title 'Plugins that can be used as a tool' 7) In menu select 'View report plugins' 6) Check you see message 'No plugins installed' and title 'Plugins that can create a report' 7) Edit URL and go to /cgi-bin/koha/plugins/plugins-home.pl?method=opac_js 8) Check you see message 'No plugins installed' and title 'Plugins with class opac_js' I don't like that this uses the button toolbar to switch views, based on my conception of our conventions of views and actions: https://wiki.koha-community.org/wiki/Interface_patterns#Views_and_Actions I would prefer that the views be links in the sidebar or some kind of DataTables filter. I think it's not ideal that one is offered choices to view classes of plugins for which there are no results. This would be an advantage of making the table a DataTable, including the class as a (hidden?) column, and offering table filtering based on the available classes. Indeed changing to a DataTable whould be great.
> including the class as a (hidden?) column, and offering table filtering based on the available classes.
Just we must remind that a plugin may have several classes.
Thanks for your advice
I believe the page/table have changed since, any chance to revive? (In reply to Owen Leonard from comment #2) > I don't like that this uses the button toolbar to switch views, based on my > conception of our conventions of views and actions: > > https://wiki.koha-community.org/wiki/Interface_patterns#Views_and_Actions > > I would prefer that the views be links in the sidebar or some kind of > DataTables filter. > > I think it's not ideal that one is offered choices to view classes of > plugins for which there are no results. This would be an advantage of making > the table a DataTable, including the class as a (hidden?) column, and > offering table filtering based on the available classes. This is the best solution so I close this one invalid. |