|
Description
Barbara Johnson
2020-12-10 16:15:16 UTC
Created attachment 115274 [details] [review] Bug 27193 - Set focus for cursor to patron attribute type code input box when creating new patron attributes 1. (Before attaching the patch) Go into administration 2. Go to Patron attribute types - then 'New patron attribute type' 3. Without the patch, the cursor should not automatically focus on the first container 'Patron attribute type code' 4. Install patch 5. Redo steps 1&2 6. If the patch worked, then the cursor should automatically focus to the first container 'Patron attribute type code' Sponsored.by: Catalyst IT Hello Ella, The commit message of your patch must start with "Bug 27193: ". Can you resubmit please? Created attachment 115347 [details] [review] Bug 27193: Set focus for cursor to patron attribute type code input box when creating new patron attributes 1. (Before attaching the patch) Go into administration 2. Go to Patron attribute types - then 'New patron attribute type' 3. Without the patch, the cursor should not automatically focus on the first container 'Patron attribute type code' 4. Install patch 5. Redo steps 1&2 6. If the patch worked, then the cursor should automatically focus to the first container 'Patron attribute type code' Sponsored.by: Catalyst IT Created attachment 115366 [details] [review] Bug 27195: Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city container (It shouldn't). 5. Apply patch 6. Repeat steps 1-4 7. If the cursor automatically focuses in the first city container, the patch has worked! Sponsored-by: Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 115367 [details] [review] Bug 27193 - Set focus for cursor to patron attribute type code input box when creating new patron attributes 1. (Before attaching the patch) Go into administration 2. Go to Patron attribute types - then 'New patron attribute type' 3. Without the patch, the cursor should not automatically focus on the first container 'Patron attribute type code' 4. Install patch 5. Redo steps 1&2 6. If the patch worked, then the cursor should automatically focus to the first container 'Patron attribute type code' Sponsored.by: Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 115616 [details] [review] Bug 27193: Set focus for cursor to patron attribute type code input box when creating new patron attributes 1. (Before attaching the patch) Go into administration 2. Go to Patron attribute types - then 'New patron attribute type' 3. Without the patch, the cursor should not automatically focus on the first container 'Patron attribute type code' 4. Install patch 5. Redo steps 1&2 6. If the patch worked, then the cursor should automatically focus to the first container 'Patron attribute type code' Sponsored.by: Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Focus must be put using the "focus" class instead. Created attachment 139416 [details] [review] Bug 27193: Set focus on first input when adding a new patron attribute When adding a new patron attribute, the focus/cursor should be in the first input field of the form: Patron attribute type code To test: * Add a new patron attribute - cursur is in no field * Apply patch * Add another new patron attribute - cursor is now in the first input field: Patron attribute type code I've implemented the solution from comment#7 using the CSS class. As this is a one line change all in all it replaces Ella's patch. I am sorry to lose the contribution, but not sure about a better option here. :( Created attachment 139424 [details] [review] Bug 27193: Set focus on first input when adding a new patron attribute When adding a new patron attribute, the focus/cursor should be in the first input field of the form: Patron attribute type code To test: * Add a new patron attribute - cursur is in no field * Apply patch * Add another new patron attribute - cursor is now in the first input field: Patron attribute type code Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 140158 [details] [review] Bug 27193: Set focus on first input when adding a new patron attribute When adding a new patron attribute, the focus/cursor should be in the first input field of the form: Patron attribute type code To test: * Add a new patron attribute - cursur is in no field * Apply patch * Add another new patron attribute - cursor is now in the first input field: Patron attribute type code Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! |