|
Description
Barbara Johnson
2020-12-10 16:18:26 UTC
There are quite a few similar bugs with recent patches that can be used to see how this can be done. Look for "focus", an example would be bug 27192. *** Bug 27456 has been marked as a duplicate of this bug. *** Created attachment 115264 [details] [review] bug 27195:Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city container (It shouldn't). 5. Apply patch 6. Repeat steps 1-4 7. If the cursor automatically focuses in the first city container, the patch has worked! Sponsored-by: Catalyst IT Hello Ella, The commit message must start with "Bug 27195: ". Also you should try and avoid adding empty lines as it could cause unnecessary conflicts with other patches. Created attachment 115350 [details] [review] Bug 27195: Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city con Sponsored-by: Catalyst IT Created attachment 115355 [details] [review] Bug 27195: Set focus for cursor to city input bo when creating new cities Was removing an empty line in the patch (For testing, do the same tests as above) Created attachment 115360 [details] [review] Bug 27195: Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city container (It shouldn't). 5. Apply patch 6. Repeat steps 1-4 7. If the cursor automatically focuses in the first city container, the patch has worked! Sponsored-by: Catalyst IT Created attachment 115365 [details] [review] Bug 27195: Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city container (It shouldn't). 5. Apply patch 6. Repeat steps 1-4 7. If the cursor automatically focuses in the first city container, the patch has worked! Sponsored-by: Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 115615 [details] [review] Bug 27195: Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city container (It shouldn't). 5. Apply patch 6. Repeat steps 1-4 7. If the cursor automatically focuses in the first city container, the patch has worked! Sponsored-by: Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Focus must be put using the "focus" class instead. Created attachment 139418 [details] [review] Bug 27195: Set focus on first input when adding a new city When adding a new city, the focus/cursor should be in the first input field of the form: City To test: * Add a new city in administration > cities - cursur is in no field * Apply patch * Add another new city - cursor is now in the first input field of the form: City https://bugs.koha-community.org/show_bug.cgi?id=27193 Created attachment 139422 [details] [review] Bug 27195: Set focus on first input when adding a new city When adding a new city, the focus/cursor should be in the first input field of the form: City To test: * Add a new city in administration > cities - cursur is in no field * Apply patch * Add another new city - cursor is now in the first input field of the form: City https://bugs.koha-community.org/show_bug.cgi?id=27193 Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 140732 [details] [review] Bug 27195: Set focus on first input when adding a new city When adding a new city, the focus/cursor should be in the first input field of the form: City To test: * Add a new city in administration > cities - cursur is in no field * Apply patch * Add another new city - cursor is now in the first input field of the form: City https://bugs.koha-community.org/show_bug.cgi?id=27193 Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! |