Summary: | PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | OPAC | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, caroline.cyr-la-rose, fridolin.somers |
Version: | Main | Keywords: | Manual |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch excludes the ability to add branchcode to the PatronSelfRegistrationBorrowerUnwantedField system preference.
|
Version(s) released in: |
21.05.00,20.11.03
|
Circulation function: | |||
Bug Depends on: | 17364, 22844 | ||
Bug Blocks: | 27321 | ||
Attachments: |
Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField
Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField |
Description
Lucas Gass (lukeg)
2020-12-17 15:38:44 UTC
Created attachment 114483 [details] [review] Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField To test: 1 - Alter PatronSelfRegistrationBorrowerUnwantedFieldand select branchcode 2 - Attempt to self register via the OPAC 3 - Kabloom, internal server error 4 - Apply patche 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Attempt to self register again 9 - It succeeds Great :D Maybe we need some CSS on excluded fields name, grey color for example. Created attachment 114751 [details] [review] Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField To test: 1 - Alter PatronSelfRegistrationBorrowerUnwantedFieldand select branchcode 2 - Attempt to self register via the OPAC 3 - Kabloom, internal server error 4 - Apply patche 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Attempt to self register again 9 - It succeeds Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> (In reply to Fridolin Somers from comment #2) > Great :D > > Maybe we need some CSS on excluded fields name, grey color for example. I agree, I have opened Bug 27321. Created attachment 116117 [details] [review] Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField To test: 1 - Alter PatronSelfRegistrationBorrowerUnwantedFieldand select branchcode 2 - Attempt to self register via the OPAC 3 - Kabloom, internal server error 4 - Apply patche 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Attempt to self register again 9 - It succeeds Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.03 Missing dependency, not backported to 20.05 |