| Summary: | Indirect object notation in Koha::Club::Hold | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | agustinmoyano, andrew, caroline.cyr-la-rose, david, fridolin.somers, jonathan.druart, julian.maurice, martin.renvoize, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.03,20.05.09,19.11.15
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 26303, 27333 | ||
| Attachments: |
Bug 27327: Get rid of indirect object notation in Koha::Club::Hold
Bug 27327: Get rid of indirect object notation in Koha::Club::Hold |
||
|
Description
Tomás Cohen Arazi (tcohen)
2021-01-04 13:29:01 UTC
Created attachment 114787 [details] [review] Bug 27327: Get rid of indirect object notation in Koha::Club::Hold This patch makes the code follow the PERL29 coding guideline. Period. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Applies cleanly here: $ git checkout origin/master -b qa_27327 Branch 'qa_27327' set up to track remote branch 'master' from 'origin'. Switched to a new branch 'qa_27327' (base) ✔ ~/git/koha [qa_27327|…1⚑ 28] 13:22 $ git bz apply 27327 Bug 27327 - Indirect object notation in Koha::Club::Hold 114787 - Bug 27327: Get rid of indirect object notation in Koha::Club::Hold Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27327: Get rid of indirect object notation in Koha::Club::Hold (base) ✔ ~/git/koha [qa_27327 ↑·1|…1⚑ 28] Created attachment 115826 [details] [review] Bug 27327: Get rid of indirect object notation in Koha::Club::Hold This patch makes the code follow the PERL29 coding guideline. Period. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Going for a straight QA on this one.. trivial patch, improves code quality, tests still pass, no regressions found. Passing QA Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.03 For perl 7 wahooo. "To infinity and beyond ..." Pushed to 20.05.x for 20.05.09 Backported: Pushed to 19.11.x branch for 19.11.15 |