|
Description
Katrin Fischer
2021-01-04 13:54:36 UTC
Created attachment 114834 [details] [review] Bug 27332: Use the branchcode from the subscription when renewing What's the point (/expected behaviour) of this branchcode dropdown? Reading the code it seems that it's only used when RenewSerialAddsSuggestion is set. The new suggestion will have this branchcode defined but it won't modify the subscription. Hi Jonathan, I came to the same conclusion yesterday when I tried to document it for our users. I think it should preselect either the currently logged in library or the library of the subscription (maybe second with a fallback to first as a lot of single branch libraries don't set the library in the subscription consistently). But it should only show when RenewSerialAddsSuggestion is turned on, which was not the case here. Same for the note field "to the librarian" below. I think this is lost when the feature is turned off as well. Created attachment 114854 [details] [review] Bug 27332: Hide branchcode and note is RenewSerialAddsSuggestion if off Created attachment 116479 [details] [review] Bug 27332: Hide branchcode and note is RenewSerialAddsSuggestion if off Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 116480 [details] [review] Bug 27332: Use the branchcode from the subscription when renewing Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 116481 [details] [review] Bug 27332: Hide branchcode and note is RenewSerialAddsSuggestion if off Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thank you for the patches, Jonathan! Created attachment 117167 [details] [review] Bug 27332: Use the branchcode from the subscription when renewing Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 117168 [details] [review] Bug 27332: Hide branchcode and note is RenewSerialAddsSuggestion if off Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected, no regressions found, QA script passes. Passing QA Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.04 Pushed to 20.05.x for 20.05.10 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |