Bug 27337

Summary:	Remove direct use of CGI::Cookie
Product:	Koha	Reporter:	Jonathan Druart <jonathan.druart>
Component:	Architecture, internals, and plumbing	Assignee:	Bugs List <koha-bugs>
Status:	NEW ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	dcook, josef.moravec
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 27337: Remove direct use of CGI::Cookie

Description Jonathan Druart 2021-01-05 05:41:14 UTC

We should not use CGI::Cookie directly, CGI is using it internally.

See also bug 11299 comment 188

Comment 1 Jonathan Druart 2021-01-05 15:25:05 UTC

Created attachment 114883 [details] [review]
Bug 27337: Remove direct use of CGI::Cookie

There is only 1 occurrence where there is an explanation about the
direct use of CGI::Cookie, in tools/upload-file.pl

The others don't seem relevant

Comment 2 Jonathan Druart 2021-01-05 15:25:24 UTC

This patch will be a nightmare to test...

Comment 3 David Cook 2021-01-05 22:31:51 UTC

(In reply to Jonathan Druart from comment #2)
> This patch will be a nightmare to test...

Agreed. Perhaps it's better to use this as a omnibus bug and do the changes in separate bugs with specific test plans for those pages.