|
Description
Katrin Fischer
2021-01-11 21:34:33 UTC
Created attachment 115261 [details] [review] Bug 25054: (QA follow-up) Add space after comma for multiple aliases Just a little formatting change to help readability by adding a space after comma: alias1, alias2, ... Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Catherine Ma <catherinem2003@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=27397 Signed-off-by: Catherine Ma <catherinem2003@gmail.com> Created attachment 115289 [details] [review] Bug 27397: The description input field when defining numbering patterns is too short Test Plan: 1. go to the serials module 2. click on manage numbering patterns in the left hand navigation 3. add or edit a pattern 4. check the description field is as short as the name field, but can take much more text 5. add patch 6. repeat steps 1-3 7. check the description field is larger than the name field (it should) Sponsored by Catalyst IT Hi Catherine, I don't think the following change is needed: - <input type="text" id="label" name="label" value="[% label | html %]" /> + <input type="text" id="label" name="label" value="[% label | html %]" > Created attachment 115361 [details] [review] Bug 27397: The description input field when defining numbering patterns is too short Test Plan: 1. go to the serials module 2. click on manage numbering patterns in the left hand navigation 3. add or edit a pattern 4. check the description field is as short as the name field, but can take much more text 5. add patch 6. repeat steps 1-3 7. check the description field is larger than the name field (it should) Sponsored by Catalyst IT I don't know wheter this has something to do with this patch. I got an error after klicking on the Save button for saving a new numbering pattern at testing this patch.
The description field is indeed longer than before.
First lines of error trace:
C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_christian8`.`subscription_numberpatterns`.`displayorder` at row 1 [for Statement "INSERT INTO subscription_numberpatterns(label,description,numberingmethod,displayorder,label1,label2,label3,add1,add2,add3,every1,every2,every3,setto1,setto2,setto3,whenmorethan1,whenmorethan2,whenmorethan3,numbering1,numbering2,numbering3) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)" with ParamValues: 0="blablub", 1="blablubdescription", 2="{X}, H. {Y} {Z} ", 3="", 4="Jahr", 5="Jahrgang", 6="Heft", 7="1", 8="1", 9="1", 10="12", 11="6", 12="1", 13="1", 14="1", 15="1", 16="9999", 17="9999", 18="6", 19="", 20="", 21=""] at /kohadevbox/koha/serials/subscription-numberpatterns.pl line 62
at /usr/share/perl5/DBIx/Class/Exception.pm line 77
Addition: if i'm emptying the Numbering formula field, i won't get an error after saving, but the New numbering pattern won't be saved (on the surface?) The order appears when you create a new numbering patterns and the "display order" is empty. It's a bug that is not directly related to this patch and bug report. Can you open a new one please? (In reply to Jonathan Druart from comment #7) > The order appears when you create a new numbering patterns and the "display > order" is empty. It's a bug that is not directly related to this patch and > bug report. Can you open a new one please? s/order/error Created attachment 118590 [details] [review] Bug 27397: The description input field when defining numbering patterns is too short Test Plan: 1. go to the serials module 2. click on manage numbering patterns in the left hand navigation 3. add or edit a pattern 4. check the description field is as short as the name field, but can take much more text 5. add patch 6. repeat steps 1-3 7. check the description field is larger than the name field (it should) Created attachment 118809 [details] [review] Bug 27397: The description input field when defining numbering patterns is too short Test Plan: 1. go to the serials module 2. click on manage numbering patterns in the left hand navigation 3. add or edit a pattern 4. check the description field is as short as the name field, but can take much more text 5. add patch 6. repeat steps 1-3 7. check the description field is larger than the name field (it should) Sponsored by Catalyst IT Works OK! Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial display fix, Passing QA Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.05 Pushed to 20.05.x for 20.05.11 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |