Description
Martin Renvoize (ashimema)
2021-01-12 10:21:38 UTC
Created attachment 115396 [details] [review] Bug 27408: pdate intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful There is more to do when converting a "type='number'" input: If present, the "step," "max," and "min" attributes should be removed too. They are invalid if applied to a standard text input. Example errors from the w3c validator: Error: Attribute step not allowed on element input at this point. Error: Attribute min not allowed on element input at this point. Created attachment 115467 [details] [review] Bug 27408: pdate intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful Created attachment 115469 [details] [review] Bug 27408: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful Created attachment 115483 [details] [review] Bug 27408: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful Signed-off-by: Owen Leonard <oleonard@myacpl.org> Whoops, I was too hasty with this signoff. The regex validating the modified field doesn't allow for currency-formatted values like "1.00" because of the dot. Created attachment 115549 [details] [review] Bug 27408: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 115550 [details] [review] Bug 27408: (follow-up) Updates to accommodate currency entry This patch makes two modifications in order to allow the entry of currency strings (e.g. 1.25). - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual credit "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. Created attachment 117014 [details] [review] Bug 27408: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Created attachment 117015 [details] [review] Bug 27408: (follow-up) Updates to accommodate currency entry This patch makes two modifications in order to allow the entry of currency strings (e.g. 1.25). - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual credit "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. Signed-off-by: David Nind <david@davidnind.com> Testing notes: - For step 2 of the test plan, input type="text" should be input type="number", the same as bug 27410 Created attachment 117707 [details] [review] Bug 27408: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 Test Plan: 1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt 2. Search for instances of 'input type="text" 3. If none are found then patch was successful Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 117708 [details] [review] Bug 27408: (follow-up) Updates to accommodate currency entry This patch makes two modifications in order to allow the entry of currency strings (e.g. 1.25). - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual credit "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! I've dediced not pushed to 20.11.x changes for ACC2 |