Bug 27411

Summary: Update tools/automatic_item_modification_by_age.tt to reflect ACC2
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Staff interfaceAssignee: James O'Keeffe <jamespfk>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, gmcharlt, jamespfk, jonathan.druart
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.05.00
Bug Depends on:    
Bug Blocks: 26926    
Attachments: Bug 27411: Update intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt to reflect ACC2
Bug 27411: Update intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt to reflect ACC2
Bug 27411: Update intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt to reflect ACC2
Bug 27411: Update tools/automatic_item_modification_by_age.tt to reflect ACC2

Description Martin Renvoize 2021-01-12 10:25:32 UTC
Inputs of type="number" need updating to reflect ACC2 on intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
Comment 1 James O'Keeffe 2021-01-20 01:31:53 UTC
Created attachment 115390 [details] [review]
Bug 27411: Update intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt to reflect ACC2

This patch changes instances of type="number" in inputs to adhere to
ACC2 guidelines

Test plan:
Open the file and ensure all instances of type="number" in inputs are
changed to 'type="text" inputmode="numeric" pattern="[0-9]*"'
Comment 2 Owen Leonard 2021-01-20 17:00:40 UTC
Created attachment 115450 [details] [review]
Bug 27411: Update intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt to reflect ACC2

This patch changes instances of type="number" in inputs to adhere to
ACC2 guidelines

Test plan:
Open the file and ensure all instances of type="number" in inputs are
changed to 'type="text" inputmode="numeric" pattern="[0-9]*"'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize 2021-01-21 10:05:56 UTC
Created attachment 115516 [details] [review]
Bug 27411: Update intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt to reflect ACC2

This patch changes instances of type="number" in inputs to adhere to
ACC2 guidelines

Test plan:
Open the file and ensure all instances of type="number" in inputs are
changed to 'type="text" inputmode="numeric" pattern="[0-9]*"'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2021-01-21 10:06:21 UTC
Another nice clear and clean patch, thanks James

Passing QA
Comment 5 Jonathan Druart 2021-01-21 14:55:27 UTC
Created attachment 115556 [details] [review]
Bug 27411: Update tools/automatic_item_modification_by_age.tt to reflect ACC2

This patch changes instances of type="number" in inputs to adhere to
ACC2 guidelines

Test plan:
Open the file and ensure all instances of type="number" in inputs are
changed to 'type="text" inputmode="numeric" pattern="[0-9]*"'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Jonathan Druart 2021-01-21 15:25:31 UTC
Pushed to master for 21.05, thanks to everybody involved!