Bug 2742

Summary: Wrong language name in the preferences
Product: Koha Reporter: Chris Cormack <chris>
Component: I18N/L10NAssignee: Chris Cormack <chris>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: colin.campbell, m.de.rooy, magnus, nengard
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Follow up patch for Dutch
Followup patch for Norwegian
Follow up patch for Dutch

Description Chris Cormack 2010-05-21 00:55:21 UTC 


---- Reported by axelb@skolelinux.no 2008-10-30 06:00:39 ----

/cgi-bin/koha/admin/systempreferences.pl?op=add_form&searchfield=language
-> Not translatable, and seems to need a real clean up. For Norwegian it would for instance need to be "Norwegian Bokmål" and "Norwegian Nynorsk" instead of "Norsk(nb-NO)"
and "(nn-NO)" (where nb-NO means Norwegian Bokmål).



---- Additional Comments From nengard@gmail.com 2009-12-21 13:39:37 ----

Will this be addressed by the new sys pref edits done by Jesse?



---- Additional Comments From pianohacker@gmail.com 2009-12-22 19:03:25 ----

(In reply to comment #1)
> Will this be addressed by the new sys pref edits done by Jesse?
> 

Unfortunately not. The language names come from a different database table, and would need to be addressed by a separate rewrite.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:55 UTC  ---

This bug was previously known as _bug_ 2742 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2742

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was axelb@skolelinux.no.
CC member pianohacker@gmail.com does not have an account here
Comment 1 Magnus Enger 2010-10-05 18:15:18 UTC 
nn-NO (Norwegian "nynorsk") is missing from subtag_registry.sql. This results in "nynorsk" being displayed as nn-NO in the language chooser, the preferences etc.
Comment 2 Colin Campbell 2011-02-07 16:31:26 UTC 
At least two languages are incorrectly spelt in their native tongue. Danish and Dutch should be Dansk and nederlands currebtly they seem to have phonetic spellings.
Comment 3 Chris Cormack 2011-02-08 08:20:37 UTC 
Pushed, please test
Comment 4 Magnus Enger 2011-02-08 09:15:32 UTC 
I'll try and submit a patch that adds "nynorsk" in all the right places too.
Comment 5 Marcel de Rooy 2011-02-14 11:26:30 UTC 
I have sent a follow up patch to rename the Dutch translation too in the about template.
Comment 6 Marcel de Rooy 2011-02-14 11:27:44 UTC Comment hidden (obsolete)
Comment 7 Chris Cormack 2011-02-14 21:28:31 UTC 
Signed off and pushed the follow up patch, please test
Comment 8 Magnus Enger 2011-02-15 10:43:46 UTC 
Created attachment 3156 [details] [review]
Followup patch for Norwegian

Replace "Norwegian" with "Norwegian bokmål", add "Norwegian nynorsk". 

See it in action here: 
http://demo.bibkat.no/ (language chooser at the bottom of the page)
http://demo.bibkat.no:8080/cgi-bin/koha/admin/preferences.pl?tab=i18n-l10n (logon with test1/test1, see language chooser at the bottom of the page, and the language and opaclanguages sysprefs). 

Tested with current master and the 3.2.x branch.
Comment 9 Chris Cormack 2011-02-16 22:41:54 UTC 
Pushed follow up patch, please test
Comment 10 Marcel de Rooy 2011-02-21 14:00:45 UTC 
Created attachment 3189 [details] [review]
Follow up patch for Dutch

Second follow up. Sorry for the inconvenience. Improvement, suggested by Belgian translators (Hans Supply).
Comment 11 Chris Cormack 2011-02-21 19:47:21 UTC 
Follow up pushed, please test
Comment 12 Marcel de Rooy 2011-02-23 12:57:28 UTC 
The signed patch introduced a small problem related to encoding. Follow up patch fixes diacritic on e in België (Belgium).
Comment 13 Chris Cormack 2011-02-27 20:10:23 UTC 
Follow up patches pushed