Summary: | A mistake in bug 5161 leads to some patron attributes appearing without a fieldset | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Patrons | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | andrew, caroline.cyr-la-rose, fridolin.somers, george, gmcharlt, jonathan.druart, kyle.m.hall, sally.healey, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.02,20.05.08
|
|
Circulation function: | |||
Bug Depends on: | 5161 | ||
Bug Blocks: | |||
Attachments: |
Bug 27420: Use object accessor for $attr_type->class()
Bug 27420: Use object accessor for $attr_type->class() Bug 27420: Use object accessor for $attr_type->class() |
Description
Martin Renvoize (ashimema)
2021-01-13 11:16:53 UTC
Created attachment 115110 [details] [review] Bug 27420: Use object accessor for $attr_type->class() We introduced a bug in the patron attribute forms with bug 5161. Test plan 1/ Create two PA_CLASS authorized values 2/ Create two corresponding patron attribute types referencing the above classes. 3/ Edit a patron, both attributes should appear within their own fieldsets at the bottom of the member entry form. 4/ Set a value for the first of the two patron attributes and save 5/ Edit the patron again, note that the first attribute no longer resides within it's own fieldset 6/ Apply the patch 7/ Edit the patron again, note that the first attribute now resides inside it's own fieldset again 8/ Signoff Created attachment 115114 [details] [review] Bug 27420: Use object accessor for $attr_type->class() We introduced a bug in the patron attribute forms with bug 5161. Test plan 1/ Create two PA_CLASS authorized values 2/ Create two corresponding patron attribute types referencing the above classes. 3/ Edit a patron, both attributes should appear within their own fieldsets at the bottom of the member entry form. 4/ Set a value for the first of the two patron attributes and save 5/ Edit the patron again, note that the first attribute no longer resides within it's own fieldset 6/ Apply the patch 7/ Edit the patron again, note that the first attribute now resides inside it's own fieldset again 8/ Signoff Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> This works well and I am passing QA, but there is some other oddity as the entries change sequence every time you reload the page. Filed as: bug 27454 Created attachment 115223 [details] [review] Bug 27420: Use object accessor for $attr_type->class() We introduced a bug in the patron attribute forms with bug 5161. Test plan 1/ Create two PA_CLASS authorized values 2/ Create two corresponding patron attribute types referencing the above classes. 3/ Edit a patron, both attributes should appear within their own fieldsets at the bottom of the member entry form. 4/ Set a value for the first of the two patron attributes and save 5/ Edit the patron again, note that the first attribute no longer resides within it's own fieldset 6/ Apply the patch 7/ Edit the patron again, note that the first attribute now resides inside it's own fieldset again 8/ Signoff Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.02 Pushed to 20.05.x for 20.05.08 Missing dependencies for 19.11.x, shouldn't be affected, no backport. |