| Summary: | HTML5Media is http by default but Youtube is https only | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Didier Gautheron <didier.gautheron> |
| Component: | Cataloging | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | andrew, caroline.cyr-la-rose, dcook, fridolin.somers, m.de.rooy, tomascohen, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.03,20.05.09,19.11.15
|
|
| Circulation function: | |||
| Attachments: |
Bug 27422: YouTube videos are HTTPS only
Bug 27422: YouTube videos are HTTPS only Bug 27422: YouTube videos are HTTPS only |
||
|
Description
Didier Gautheron
2021-01-13 12:17:26 UTC
Created attachment 116297 [details] [review] Bug 27422: YouTube videos are HTTPS only This patch hardcodes HTTPS as the protocol to use when generating YouTube content embedding. It is the supported protocol and without this patch it falls back to 'http', or it can be 'ftp' depending on the first indicator of the 856 field. They are all not supported so hardcoding it. To test: 1. Have a record with 856 $uhttps://youtu.be/sMNkDPFycNU 2. Enable the HTML5MediaYouTube and HTML5Media sysprefs 3. Open the OPAC detailed view of the record 4. Open the Multimedia tab => FAIL: There's no embedded video 5. Apply this patch 6. Restart all 7. Repeat 4 => SUCCESS: There's a live performance of Heroes del Silencio! 8. Sign off :-D Sponsored-by: Banco Central de la República Argentina Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> This should be backported to all stable branches. Hmm, I have no problem without the patch. I do see that https://youtu.be/sMNkDPFycNU has been changed to http://www.youtube.com/embed/sMNkDPFycNU in the iframe though. I'm going to try the patch anyway though because changing HTTPS to HTTP is silly. Created attachment 116308 [details] [review] Bug 27422: YouTube videos are HTTPS only This patch hardcodes HTTPS as the protocol to use when generating YouTube content embedding. It is the supported protocol and without this patch it falls back to 'http', or it can be 'ftp' depending on the first indicator of the 856 field. They are all not supported so hardcoding it. To test: 1. Have a record with 856 $uhttps://youtu.be/sMNkDPFycNU 2. Enable the HTML5MediaYouTube and HTML5Media sysprefs 3. Open the OPAC detailed view of the record 4. Open the Multimedia tab => FAIL: There's no embedded video 5. Apply this patch 6. Restart all 7. Repeat 4 => SUCCESS: There's a live performance of Heroes del Silencio! 8. Sign off :-D Sponsored-by: Banco Central de la República Argentina Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Cook <dcook@prosentient.com.au> Created attachment 116463 [details] [review] Bug 27422: YouTube videos are HTTPS only This patch hardcodes HTTPS as the protocol to use when generating YouTube content embedding. It is the supported protocol and without this patch it falls back to 'http', or it can be 'ftp' depending on the first indicator of the 856 field. They are all not supported so hardcoding it. To test: 1. Have a record with 856 $uhttps://youtu.be/sMNkDPFycNU 2. Enable the HTML5MediaYouTube and HTML5Media sysprefs 3. Open the OPAC detailed view of the record 4. Open the Multimedia tab => FAIL: There's no embedded video 5. Apply this patch 6. Restart all 7. Repeat 4 => SUCCESS: There's a live performance of Heroes del Silencio! 8. Sign off :-D Sponsored-by: Banco Central de la República Argentina Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Small useful, I choose to backport. Pushed to 20.11.x for 20.11.03 Pushed to 20.05.x for 20.05.09 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. (In reply to Victor Grousset/tuxayo from comment #9) > Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. Please backport it. It is a broken feature without it. Thanks Backported: Pushed to 19.11.x branch for 19.11.15 > Please backport it. It is a broken feature without it. Thanks
Ok, I didn't understood that from the severity and description. Done! :)
Though I'm still confused as in my testing it still works without the patch.
(In reply to Victor Grousset/tuxayo from comment #12) > Though I'm still confused as in my testing it still works without the patch. Same (In reply to Victor Grousset/tuxayo from comment #12) > > Please backport it. It is a broken feature without it. Thanks > > Ok, I didn't understood that from the severity and description. Done! :) > > Though I'm still confused as in my testing it still works without the patch. It might be related to some specific browsers not accepting http on iframes. I'm not sure. We've been having reports since December and we ground this bug. I usually try Firefox, Chrome and Safari. > It might be related to some specific browsers not accepting http on iframes.
Must be that! My local Koha isn't in HTTPS, but if it was, maybe the issue would happen.
|