| Summary: | OPAC header tweaks for non-JavaScript users | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 28662 | ||
| Attachments: |
Bug 27445: OPAC header tweaks for non-JavaScript users
Bug 27445: OPAC header tweaks for non-JavaScript users Bug 27445: OPAC header tweaks for non-JavaScript users |
||
|
Description
Owen Leonard
2021-01-15 19:38:37 UTC
Created attachment 115212 [details] [review] Bug 27445: OPAC header tweaks for non-JavaScript users This patch makes some minor changes to the header menu in the OPAC visible only to users with JavaScript support. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the OPAC with JS disabled in your browser. - The "Cart" button should not be visible. - The "List," "Log in," and "Search history" links should be styled blue like other links. - Log in to the OPAC and confirm that the "Welcome <name>" link is also styled like other links. - Enable JavaScript and verify that the links appear and function just as they did before the patch. Created attachment 120848 [details] [review] Bug 27445: OPAC header tweaks for non-JavaScript users This patch makes some minor changes to the header menu in the OPAC visible only to users with JavaScript support. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the OPAC with JS disabled in your browser. - The "Cart" button should not be visible. - The "List," "Log in," and "Search history" links should be styled blue like other links. - Log in to the OPAC and confirm that the "Welcome <name>" link is also styled like other links. - Enable JavaScript and verify that the links appear and function just as they did before the patch. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> I believe this is a clear improvement to "without the patch", but I was not able to log out without JavaScript, so have filed a new bug report: bug 28662 Created attachment 122579 [details] [review] Bug 27445: OPAC header tweaks for non-JavaScript users This patch makes some minor changes to the header menu in the OPAC visible only to users with JavaScript support. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the OPAC with JS disabled in your browser. - The "Cart" button should not be visible. - The "List," "Log in," and "Search history" links should be styled blue like other links. - Log in to the OPAC and confirm that the "Welcome <name>" link is also styled like other links. - Enable JavaScript and verify that the links appear and function just as they did before the patch. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! Not pushed for 21.05 |