|
Description
Martin Renvoize (ashimema)
2021-01-20 09:03:30 UTC
Created attachment 115416 [details] [review] Bug 27493: Set column wifth for checkbox only columns This patch updates the global OPAC css such that selectcol type columns in tables are fixed width at 1ch to ensure these columns do not get unneccessarily wide. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test plan PAGES: opac-basket, opac-messaging, opac-results, opac-search-history, opac-suggestions and opac-tags. 1/ Notice that the column containing a checkbox on each of the above pages is of a mised width, often much larger than required 2/ Apply the patch and rebuild the css file as described above 3/ Notices that the column containing a checkbox on each fo the above pages is now of a standard, sensible, width. 4/ Signoff Created attachment 115428 [details] [review] Bug 27493: Add styling for hidden columns I'm sure adding a 'hidden' class to a table column used to remove it from display entirely.. seems that's no longer the case so we add the CSS back in here. Created attachment 115753 [details] [review] Bug 27493: Set column wifth for checkbox only columns This patch updates the global OPAC css such that selectcol type columns in tables are fixed width at 1ch to ensure these columns do not get unneccessarily wide. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test plan PAGES: opac-basket, opac-messaging, opac-results, opac-search-history, opac-suggestions and opac-tags. 1/ Notice that the column containing a checkbox on each of the above pages is of a mised width, often much larger than required 2/ Apply the patch and rebuild the css file as described above 3/ Notices that the column containing a checkbox on each fo the above pages is now of a standard, sensible, width. 4/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 115754 [details] [review] Bug 27493: Add styling for hidden columns I'm sure adding a 'hidden' class to a table column used to remove it from display entirely.. seems that's no longer the case so we add the CSS back in here. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described in all locations. Whilst testing, I noticed an issue on the tooltip for opac-messaging.pl so I've logged that as another bug. Bug 27543. Created attachment 115847 [details] [review] Bug 27493: Add styling for hidden columns I'm sure adding a 'hidden' class to a table column used to remove it from display entirely.. seems that's no longer the case so we add the CSS back in here. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 115922 [details] [review] Bug 27493: Set column width for checkbox only columns This patch updates the global OPAC css such that selectcol type columns in tables are fixed width at 1ch to ensure these columns do not get unneccessarily wide. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test plan PAGES: opac-basket, opac-messaging, opac-results, opac-search-history, opac-suggestions and opac-tags. 1/ Notice that the column containing a checkbox on each of the above pages is of a mised width, often much larger than required 2/ Apply the patch and rebuild the css file as described above 3/ Notices that the column containing a checkbox on each fo the above pages is now of a standard, sensible, width. 4/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 115923 [details] [review] Bug 27493: Add styling for hidden columns I'm sure adding a 'hidden' class to a table column used to remove it from display entirely.. seems that's no longer the case so we add the CSS back in here. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> - Fixed typo in first patch wifth vs width - Added missing signed-off-by line from QA I don't think we need the 2 classes, "select" and "selectcol". I didn't find .select in the .scss files, and the only places it was used was opac-results.tt, where it has been removed. Owen, can you take a look please? Created attachment 115932 [details] [review] Bug 27493: (follow-up) Remove redundant class This patch modifies the templates so that instances of "class='select selectcol' are replaced with "class='selectcol'". I could find no instances of the "select" class being used in CSS or JS. Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |