Summary: | Add description to reports page | ||
---|---|---|---|
Product: | Koha | Reporter: | Christofer Zorn <christofer.zorn> |
Component: | Reports | Assignee: | Philip Orr <philip.orr> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | arthur.suzuki, david, jacob.omara, lisettepalouse+koha, lucas, philip.orr |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05,22.05.13,21.11.21
|
|
Circulation function: | |||
Attachments: |
Bug 27513: Add notes to variables for report parameters template
Bug 27513: Add notes to variables for report parameters template Bug 27513: Add notes to variables for report parameters template |
Description
Christofer Zorn
2021-01-21 17:54:45 UTC
+1 You might also make notes on how to use the form fields in the notes and it would be helpful to see those earlier. Looks like the template file for the Report parameters page actually already had TT code to display the notes field, it just wasn't getting the TT variable 'notes' from guided_reports.pl. Created attachment 149012 [details] [review] Bug 27513: Add notes to variables for report parameters template This patch adds the TT variable 'notes' to the variables that guided_reports.pl passes to the template guided_reports_start.tt during SQL parameters entry in the phase 'Run this report'. To test: 1. apply the patch 2. navigate to Reports -> Guided Reports -> Create from SQL 3. create an SQL report that includes at least one parameter, e.g.: SELECT barcode FROM items WHERE homebranch=<<Select library|branches>> the actual SQL and name of the report doesn't matter much, just make sure that you also put a note e.g. "Test text for display" in the field "Notes:" before you save the report. 4. run the report 5. the note you entered should now be displayed below the heading "Enter parameters for report..." Created attachment 149068 [details] [review] Bug 27513: Add notes to variables for report parameters template This patch adds the TT variable 'notes' to the variables that guided_reports.pl passes to the template guided_reports_start.tt during SQL parameters entry in the phase 'Run this report'. To test: 1. apply the patch 2. navigate to Reports -> Guided Reports -> Create from SQL 3. create an SQL report that includes at least one parameter, e.g.: SELECT barcode FROM items WHERE homebranch=<<Select library|branches>> the actual SQL and name of the report doesn't matter much, just make sure that you also put a note e.g. "Test text for display" in the field "Notes:" before you save the report. 4. run the report 5. the note you entered should now be displayed below the heading "Enter parameters for report..." Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Not related to this bug, but on the reports results page, the text for 'Notes:' and 'Total number of results:' aren't aligned with the labels (the text is slightly higher than the labels). Not sure whether there is already a bug for this or not. Simple fix that works as described, no issues from the QA scripts. Like David mentions, the display is a bit weird. The notes are also lacking a label, "Notes: ", when entering parameters. I think we can address that all in another bug. This gets the notes on the page so we should move it along! Created attachment 149149 [details] [review] Bug 27513: Add notes to variables for report parameters template This patch adds the TT variable 'notes' to the variables that guided_reports.pl passes to the template guided_reports_start.tt during SQL parameters entry in the phase 'Run this report'. To test: 1. apply the patch 2. navigate to Reports -> Guided Reports -> Create from SQL 3. create an SQL report that includes at least one parameter, e.g.: SELECT barcode FROM items WHERE homebranch=<<Select library|branches>> the actual SQL and name of the report doesn't matter much, just make sure that you also put a note e.g. "Test text for display" in the field "Notes:" before you save the report. 4. run the report 5. the note you entered should now be displayed below the heading "Enter parameters for report..." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Backported to 22.05.x for upcoming 22.05.13. Minor, won't backport. actually minors should also be backported for oldstable : try and backport regardless of severity. Applied to 21.11 for 21.11.21 |