|
Description
Ava
2021-01-21 22:55:20 UTC
Created attachment 115641 [details] [review] Bug 27521: Add new item type headset image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon As the itemtype images can be displayed in the OPAC and in the staff interface we currently need to add them in 2 places as one cannot access the image files of the other. Can you also add the files to koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/carredart please? Created attachment 115708 [details] [review] Bug 27521: (follow-up) Add copy of image to carredart icons in the OPAC Created attachment 115747 [details] [review] Bug 27521: Add new item type headset image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 115748 [details] [review] Bug 27521: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described. Test Plan 1. Go to Administration>item types>modify item type 2. There should be a headset item type under the carredart 3. Modify the item type so the headset icon is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC Hi, please see comment on bug 27522 too. Can you please clear up where the icon was taken from before we add it to Koha? Created attachment 122932 [details] [review] Bug 27521: (follow-up) Adding new itemtype headset image for carredart This patch adds new version of the image which was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Project.svg Created attachment 123272 [details] [review] Bug 27521: Add new item type headset image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> Created attachment 123273 [details] [review] Bug 27521: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> Created attachment 123274 [details] [review] Bug 27521: (follow-up) Adding new itemtype headset image for carredart This patch adds new version of the image which was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Project.svg Signed-off-by: David Nind <david@davidnind.com> Created attachment 123927 [details] [review] Bug 27521: Add new item type headset image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123928 [details] [review] Bug 27521: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123929 [details] [review] Bug 27521: (follow-up) Adding new itemtype headset image for carredart This patch adds new version of the image which was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Project.svg Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> The question here is which icon to keep - I like Owen's a little better as it's not as heavy and matches the style of the other carredart icons a little better. But then we should possibly only add his to the repo and remove the first 2 patches? Owen, could you provide your icon as a 'only' patch? Created attachment 123939 [details] [review] Bug 27521: Add new item type headset image for carredart The image added by this patch was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Project.svg TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 123955 [details] [review] Bug 27521: Add new item type headset image for carredart The image added by this patch was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Project.svg TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Based on bug 27522 comment 22 I have decided to restore the original version of the icon Pushed to master for 21.11, thanks to everybody involved! |
_-_The_Noun_Project.svg){kind=link}